From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitsyanko Igor Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Tue, 31 Jan 2012 18:01:26 +0400 Message-ID: <4F27F436.9020801@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> Reply-To: i.mitsyanko@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , quintela@redhat.com, KVM devel mailing list , Developers qemu-devel , Dmitry Solodkiy To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:22452 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752717Ab2AaOB3 (ORCPT ); Tue, 31 Jan 2012 09:01:29 -0500 Received: from euspt2 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LYO00HEM1MFZ7@mailout2.w1.samsung.com> for kvm@vger.kernel.org; Tue, 31 Jan 2012 14:01:27 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LYO00DW31MEL3@spt2.w1.samsung.com> for kvm@vger.kernel.org; Tue, 31 Jan 2012 14:01:27 +0000 (GMT) In-reply-to: <4F27E98E.2080501@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/31/2012 05:15 PM, Andreas F=C3=A4rber wrote: > Am 31.01.2012 00:53, schrieb Anthony Liguori: >> On 01/30/2012 05:41 PM, Andreas F=C3=A4rber wrote: >>> Am 30.01.2012 19:55, schrieb Juan Quintela: >>>> Please send in any agenda items you are interested in covering. > >>> VMState: >>> Anthony specifically said that VMState were not affected by QOM and= that >>> patches should not be deferred until the merge. Yet there's no revi= ew >>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC. >> >> Do you have pointers (to pending VMState patches)? > > http://patchwork.ozlabs.org/patch/137732/ (PATCH v4) > > It's basically about how to deal with variable-sized arrays. (Alex > mentioned it on one call around November.) I found ways to deal with > subsets of arrays embedded within the struct and variable-sized list = of > pointers to structs but no solution for a malloc()'ed array of struct= s. > Maybe I'm just too stupid to see. Anyway, no one commented since Xmas= =2E > > Igor posted (and refined for v2) a patch with a callback-based approa= ch > that I find promising. From my view, unofficially Juan is the VMState > guy, he's been cc'ed. Are we lacking an official maintainer that care= s? > Or is Juan the official, undocumented maintainer but simply busy? > > SUSE's interest is making AHCI migratable, and my VMState workaround = for > that is simply ugly: > > http://patchwork.ozlabs.org/patch/133066/ (RFC) > If I'm not mistaken, if you change AHCIState's ".ports" type to uint32_= t=20 you can use existing VMSTATE_BUFFER_MULTIPLY macro like this: VMSTATE_BUFFER_MULTIPLY(dev, AHCIState, 0, NULL, 0, ports,=20 sizeof(AHCIDevice)) VMSTATE_BUFFER_MULTIPLY currently lacks VMS_POINTER flag and therefore=20 doesn't make any use of _start field (you don't need it anyway) Nevertheless, VMSTATE_BUFFER_MULTIPLY is just a partial solution to a=20 bigger set of possible problems. SD card's vmstate implementation=20 requires shift operation, SDHC gets size from switch {} statement,=20 something else later may require division or addition e.t.c.,=20 get_bufsize callback will cover all possible cases. --=20 Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsEHA-0005b1-BJ for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsEH5-00035z-Kc for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:01:36 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:18875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsEH5-00035o-FB for qemu-devel@nongnu.org; Tue, 31 Jan 2012 09:01:31 -0500 Received: from euspt2 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LYO00CAU1MFAJ@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 31 Jan 2012 14:01:27 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LYO00DW31MEL3@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 31 Jan 2012 14:01:27 +0000 (GMT) Date: Tue, 31 Jan 2012 18:01:26 +0400 From: Mitsyanko Igor In-reply-to: <4F27E98E.2080501@suse.de> Message-id: <4F27F436.9020801@samsung.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=UTF-8 Content-transfer-encoding: QUOTED-PRINTABLE References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Developers qemu-devel , Dmitry Solodkiy , KVM devel mailing list , quintela@redhat.com On 01/31/2012 05:15 PM, Andreas F=C3=A4rber wrote: > Am 31.01.2012 00:53, schrieb Anthony Liguori: >> On 01/30/2012 05:41 PM, Andreas F=C3=A4rber wrote: >>> Am 30.01.2012 19:55, schrieb Juan Quintela: >>>> Please send in any agenda items you are interested in covering. > >>> VMState: >>> Anthony specifically said that VMState were not affected by QOM a= nd that >>> patches should not be deferred until the merge. Yet there's no re= view >>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC. >> >> Do you have pointers (to pending VMState patches)? > > http://patchwork.ozlabs.org/patch/137732/ (PATCH v4) > > It's basically about how to deal with variable-sized arrays. (Alex > mentioned it on one call around November.) I found ways to deal wit= h > subsets of arrays embedded within the struct and variable-sized lis= t of > pointers to structs but no solution for a malloc()'ed array of stru= cts. > Maybe I'm just too stupid to see. Anyway, no one commented since Xm= as. > > Igor posted (and refined for v2) a patch with a callback-based appr= oach > that I find promising. From my view, unofficially Juan is the VMSta= te > guy, he's been cc'ed. Are we lacking an official maintainer that ca= res? > Or is Juan the official, undocumented maintainer but simply busy? > > SUSE's interest is making AHCI migratable, and my VMState workaroun= d for > that is simply ugly: > > http://patchwork.ozlabs.org/patch/133066/ (RFC) > If I'm not mistaken, if you change AHCIState's ".ports" type to uint3= 2_t=20 you can use existing VMSTATE_BUFFER_MULTIPLY macro like this: VMSTATE_BUFFER_MULTIPLY(dev, AHCIState, 0, NULL, 0, ports,=20 sizeof(AHCIDevice)) VMSTATE_BUFFER_MULTIPLY currently lacks VMS_POINTER flag and therefor= e=20 doesn't make any use of _start field (you don't need it anyway) Nevertheless, VMSTATE_BUFFER_MULTIPLY is just a partial solution to a= =20 bigger set of possible problems. SD card's vmstate implementation= =20 requires shift operation, SDHC gets size from switch {} statement,= =20 something else later may require division or addition e.t.c.,=20 get_bufsize callback will cover all possible cases. --=20 Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com