All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mx6q: mx6qsabrelite: Add ECSPI support to the Sabrelite platform
Date: Tue, 31 Jan 2012 07:16:38 -0700	[thread overview]
Message-ID: <4F27F7C6.9020507@boundarydevices.com> (raw)
In-Reply-To: <CAFQ4atRDdcdouuJr_meX2s+KTtSw69LNir300nCbuRswagk-rA@mail.gmail.com>

On 01/31/2012 02:31 AM, Jason Hui wrote:
> Eric,
>
> On Tue, Jan 31, 2012 at 3:52 AM, Eric Nelson
> <eric.nelson@boundarydevices.com>  wrote:
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> Acked-by: Dirk Behme<dirk.behme@de.bosch.com>
>> Acked-by: Stefano Babic<sbabic@denx.de>
>> ---
>>   board/freescale/mx6qsabrelite/imximage.cfg    |    2 +-
>>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |   25 +++++++++++++++++++++++++
>>   include/configs/mx6qsabrelite.h               |    9 +++++++++
>>   3 files changed, 35 insertions(+), 1 deletions(-)
>
> After apply the patch, I have the build errors:
> ../mx6qsabrelite/mx6qsabrelite.c:211: undefined reference to `IMX_GPIO_NR'
>
> So, the patch should depends on others. If one patch set is depend on
> others, it's better to tell it
> in the cover letter of your patch set. Thanks.
>

Ouch! It's all about the GPIO numbers...

This occurred when I re-based to Stefano's tree and will require
another patch to keep the BANK:OFFSET numbering scheme. There's a
patch lingering in Dirk's tree that defines IMX_GPIO_NR() in gpio.h.

See http://lists.denx.de/pipermail/u-boot/2012-January/116866.html
for details.

I was hoping to get some feedback before generating a patch and
revising this patch (and removing GPIO_3_19 macro):

http://lists.denx.de/pipermail/u-boot/2012-January/116874.html

That said, I'll revise and re-send along with a patch adding
support for:
	GPIO_NUMBER(port,index)
	GPIO_PORT(number)
	GPIO_INDEX(number)

  reply	other threads:[~2012-01-31 14:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 19:52 [U-Boot] [PATCH 0/3] mxc_spi refactoring (for mx6q and mx6qsabrelite) Eric Nelson
2012-01-30 19:52 ` [U-Boot] [PATCH 1/3] mxc_spi: move machine specifics into CPU headers Eric Nelson
2012-01-31  9:15   ` Jason Hui
2012-01-30 19:52 ` [U-Boot] [PATCH 2/3] mx6q: Add support for ECSPI through mxc_spi driver Eric Nelson
2012-01-31  9:20   ` Jason Hui
2012-01-30 19:52 ` [U-Boot] [PATCH 3/3] mx6q: mx6qsabrelite: Add ECSPI support to the Sabrelite platform Eric Nelson
2012-01-31  9:31   ` Jason Hui
2012-01-31 14:16     ` Eric Nelson [this message]
2012-01-31 15:00       ` Stefano Babic
2012-01-31 17:50       ` [U-Boot] MX6q SPI refactoring and related patches Eric Nelson
2012-01-31  6:51 ` [U-Boot] [PATCH 0/3] mxc_spi refactoring (for mx6q and mx6qsabrelite) Jason Liu
2012-01-31  6:59   ` Jason Hui
2012-01-31 13:39   ` Eric Nelson
2012-02-01  4:49     ` Jason Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F27F7C6.9020507@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.