From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
Steve Dickson <SteveD@redhat.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sunrpc: initialize delayed work on each rpc_inode allocation
Date: Tue, 31 Jan 2012 16:54:44 +0200 [thread overview]
Message-ID: <4F2800B4.6040302@panasas.com> (raw)
In-Reply-To: <20120130185753.50280816@tlielax.poochiereds.net>
On 01/31/2012 01:57 AM, Jeff Layton wrote:
> WARNING: at lib/debugobjects.c:262 debug_print_object+0x8c/0xb0()
>
> For now, this patch is really just papering over that problem, but it
> should be "mostly harmless". That said, I'm ok with dropping it if
> Thomas is planning to fix this in the debugobjects code however.
>
I disagree it's harmless. What if kmem_cache_free/kmem_cache_alloc deploys
a poisoning schema, in debug mode. Which stumps over memory. Is it
initialized then?
What was the last state of the timer, is it safe for resume?
For us this is a new object we should initialize it.
Boaz
next prev parent reply other threads:[~2012-01-31 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 17:40 [PATCH] sunrpc: initialize delayed work on each rpc_inode allocation Jeff Layton
2012-01-25 11:48 ` Boaz Harrosh
2012-01-30 20:43 ` Steve Dickson
2012-01-30 21:07 ` Myklebust, Trond
2012-01-30 23:57 ` Jeff Layton
2012-01-31 14:54 ` Boaz Harrosh [this message]
2012-01-31 15:03 ` Myklebust, Trond
2012-01-31 15:12 ` Jeff Layton
2012-01-31 21:56 ` Thomas Gleixner
2012-01-31 21:56 ` Thomas Gleixner
2012-02-29 16:56 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2800B4.6040302@panasas.com \
--to=bharrosh@panasas.com \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.