From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Henningsson Subject: Re: [PATCH] ALSA: HDA: Fix jack creation for codecs with front and rear Line In Date: Tue, 31 Jan 2012 16:28:14 +0100 Message-ID: <4F28088E.5060203@canonical.com> References: <1327997055-7855-1-git-send-email-david.henningsson@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by alsa0.perex.cz (Postfix) with ESMTP id B6A732413F for ; Tue, 31 Jan 2012 16:28:16 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On 01/31/2012 03:17 PM, Takashi Iwai wrote: > At Tue, 31 Jan 2012 09:04:15 +0100, > David Henningsson wrote: >> >> If a codec has both a front and a rear Line In, two controls both >> named "Line Jack" will be created, which causes parsing to fail. >> While a long term solution might be to name the jacks differently, >> this extra check is consistent with what is already being done in many >> auto-parsers, and will also protect against other cases when two >> inputs have the same label. >> >> BugLink: https://bugs.launchpad.net/bugs/923409 >> Signed-off-by: David Henningsson > > Thanks, applied now. > > BTW, any chance to change apport to gather alsa-info.sh output? > It'd be a great help, so that we can check it via hda-emu. I have asked for this particular bug reporter to supply alsa-info as well, but may I ask you...do you have some kind of regression test script, and if so, are they public? Or could it a part of hda-emu? It would be nice if you could run "make tests" or something from the hda-emu source directory, and it would parse all codecs and report error if parsing fails (or pm fails, etc). -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic