From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RsGQs-0001gF-Hk
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:19:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RsGQn-0003cN-NS
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:19:46 -0500
Received: from thoth.sbs.de ([192.35.17.2]:27864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RsGQn-0003c7-12
	for qemu-devel@nongnu.org; Tue, 31 Jan 2012 11:19:41 -0500
Message-ID: <4F281498.9030406@siemens.com>
Date: Tue, 31 Jan 2012 17:19:36 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1327604460-31142-1-git-send-email-aliguori@us.ibm.com>
	<1327604460-31142-7-git-send-email-aliguori@us.ibm.com>
	<4F27FBE6.7040800@siemens.com> <4F27FEFD.5070507@codemonkey.ws>
	<4F28000B.5060406@siemens.com> <4F280184.3080607@redhat.com>
	<4F2812E3.6010206@codemonkey.ws>
In-Reply-To: <4F2812E3.6010206@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through
	composition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 2012-01-31 17:12, Anthony Liguori wrote:
> On 01/31/2012 08:58 AM, Paolo Bonzini wrote:
>> On 01/31/2012 03:51 PM, Jan Kiszka wrote:
>>>>>
>>>>> BTW, this is yet another benefit of making structures public. You can take the
>>>>> address of a child and set link fields directly without accessors.
>>> Well, that has two sides. We introduced properties to avoid this direct
>>> messing.
>>>
>>> Does linking also work without exposing internals?
>>
>> Perhaps it doesn't need to expose internals. Just like we create interfaces
>> automatically when creating a parent object, perhaps we can create children as
>> well, like
>>
>> TypeInfo type_piix3 = {
>> ...
>> .children = {
>> { "pic[0]", TYPE_I8259, offsetof(PIIX3, pic[0]) },
>> { "pic[1]", TYPE_I8259, offsetof(PIIX3, pic[1]) },
>> { "pit, TYPE_I8254, offsetof(PIIX3, pit) },
>> { "rtc", TYPE_RTC, offsetof(PIIX3, rtc) },
> 
> 
> Eeek.  I absolutely want to avoid any offset based interfaces.

Why?

> 
> You can just as well do:
> 
> void object_property_add_child(Object *obj, const char *name,
>                                 const char *type, Object **child);
> 
> It could then do:
> 
> *child = object_new(type);

How does this resolve where the link is stored in the opaque state
structure?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux