From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH v2 4/6] staging:iio:events: Use waitqueue lock to protect event queue
Date: Tue, 31 Jan 2012 20:58:42 +0000 [thread overview]
Message-ID: <4F285602.8010002@cam.ac.uk> (raw)
In-Reply-To: <4F282445.8000906@metafoo.de>
On 01/31/2012 05:26 PM, Lars-Peter Clausen wrote:
> On 01/29/2012 07:18 PM, Jonathan Cameron wrote:
>> On 12/19/2011 10:29 AM, Lars-Peter Clausen wrote:
>>> Use the waitqueue lock to protect the event queue instead of a custom mutex.
>>> This has the advantage that we can call the waitqueue operations with the lock
>>> held, which simplifies the code flow a bit.
>>>
>>> Acked-by: Jonathan Cameron <jic23@kernel.org>
>>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Hmm.. I really should have noticed this before.. If this hasn't gone to
>> Greg already, can you also clear out the documentation for
>> event_list_lock within struct iio_event_interface. Cleaner to do it
>> here than in a follow up patch.
>
> Yes, the whole series has already been send to Greg, but since he hasn't
> applied it yet, I suppose I could resend it with your fixes.
Either that or just send Greg a small follow up (or I'll get to it at
somepoint) None of it is remotely critical!
next prev parent reply other threads:[~2012-01-31 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 10:29 [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Lars-Peter Clausen
2011-12-19 10:29 ` [PATCH v2 6/6] staging:iio:events: Use non-atmoic bitops Lars-Peter Clausen
2011-12-19 20:59 ` Jonathan Cameron
2012-01-29 10:49 ` Jonathan Cameron
2011-12-19 20:55 ` [PATCH v2 1/6] staging:iio: Update iio_event_interface documentation Jonathan Cameron
2011-12-19 21:28 ` Lars-Peter Clausen
[not found] ` <1324290580-17511-2-git-send-email-lars@metafoo.de>
2011-12-19 20:56 ` [PATCH v2 2/6] staging:iio: Factor out event handling into its own file Jonathan Cameron
[not found] ` <1324290580-17511-3-git-send-email-lars@metafoo.de>
2011-12-19 20:56 ` [PATCH v2 3/6] staging:iio:events: Use kfifo for event queue Jonathan Cameron
[not found] ` <1324290580-17511-4-git-send-email-lars@metafoo.de>
2011-12-19 20:57 ` [PATCH v2 4/6] staging:iio:events: Use waitqueue lock to protect " Jonathan Cameron
2011-12-19 21:28 ` Lars-Peter Clausen
2012-01-29 18:18 ` Jonathan Cameron
2012-01-31 17:26 ` Lars-Peter Clausen
2012-01-31 20:58 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-01 18:45 [PATCH v2 0/6] staging:iio: Event handling updates Lars-Peter Clausen
2012-02-01 18:45 ` [PATCH v2 4/6] staging:iio:events: Use waitqueue lock to protect event queue Lars-Peter Clausen
2012-02-01 21:17 [PATCH v2 0/6] staging:iio: Event handling updates Lars-Peter Clausen
2012-02-01 21:17 ` [PATCH v2 4/6] staging:iio:events: Use waitqueue lock to protect event queue Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F285602.8010002@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.