From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse Date: Tue, 31 Jan 2012 22:49:40 +0100 Message-ID: <4F2861F4.1000604@web.de> References: <1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com> <4F285FBA.5050607@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig29C776689EE13249618D14C6" Cc: Avi Kivity , Marcelo Tosatti , Anthony Liguori , qemu-devel , kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:33508 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444Ab2AaVtp (ORCPT ); Tue, 31 Jan 2012 16:49:45 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 26D0E1C090AE0 for ; Tue, 31 Jan 2012 22:49:44 +0100 (CET) In-Reply-To: <4F285FBA.5050607@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig29C776689EE13249618D14C6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-01-31 22:40, Anthony Liguori wrote: > On 01/31/2012 12:46 PM, Jan Kiszka wrote: >> Applying the concept used for the *PICs once again: establish a base >> class for the i8254 that can be used both by the current user space >> emulation and the upcoming KVM in-kernel version. We share most of the= >> public interface of the i8254, specifically to the pcspk, vmstate, res= et >> and certain init parts. >> >> Signed-off-by: Jan Kiszka >=20 > Now that we have QOM bits, there's no need to factor out a common base > class. >=20 > Just make the methods that you want to override virtual with the defaul= t > implementation and then make a KVMPIT that inherits from the PIT and > then overrides whatever virtual functions it needs to. That doesn't sound like the proper design for this purpose. Rather, we have an abstract base class that both implementations are derived from. If I'm not using QOM properly to achieve this, please tell me. Thanks, Jan --------------enig29C776689EE13249618D14C6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8oYfQACgkQitSsb3rl5xQIoACdEh9M+TghUHJpAw81HJ/BpA3N xLgAoLt/hUj9VslPdyyBYDxXoC+CqaxQ =d6cO -----END PGP SIGNATURE----- --------------enig29C776689EE13249618D14C6-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsLaG-0004WF-Qj for qemu-devel@nongnu.org; Tue, 31 Jan 2012 16:49:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsLaE-0002e5-Hb for qemu-devel@nongnu.org; Tue, 31 Jan 2012 16:49:48 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:33507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsLaE-0002cU-59 for qemu-devel@nongnu.org; Tue, 31 Jan 2012 16:49:46 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate02.web.de (Postfix) with ESMTP id 419411C090A7E for ; Tue, 31 Jan 2012 22:49:44 +0100 (CET) Message-ID: <4F2861F4.1000604@web.de> Date: Tue, 31 Jan 2012 22:49:40 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com> <4F285FBA.5050607@codemonkey.ws> In-Reply-To: <4F285FBA.5050607@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig29C776689EE13249618D14C6" Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , Marcelo Tosatti , Avi Kivity , kvm@vger.kernel.org, qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig29C776689EE13249618D14C6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-01-31 22:40, Anthony Liguori wrote: > On 01/31/2012 12:46 PM, Jan Kiszka wrote: >> Applying the concept used for the *PICs once again: establish a base >> class for the i8254 that can be used both by the current user space >> emulation and the upcoming KVM in-kernel version. We share most of the= >> public interface of the i8254, specifically to the pcspk, vmstate, res= et >> and certain init parts. >> >> Signed-off-by: Jan Kiszka >=20 > Now that we have QOM bits, there's no need to factor out a common base > class. >=20 > Just make the methods that you want to override virtual with the defaul= t > implementation and then make a KVMPIT that inherits from the PIT and > then overrides whatever virtual functions it needs to. That doesn't sound like the proper design for this purpose. Rather, we have an abstract base class that both implementations are derived from. If I'm not using QOM properly to achieve this, please tell me. Thanks, Jan --------------enig29C776689EE13249618D14C6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8oYfQACgkQitSsb3rl5xQIoACdEh9M+TghUHJpAw81HJ/BpA3N xLgAoLt/hUj9VslPdyyBYDxXoC+CqaxQ =d6cO -----END PGP SIGNATURE----- --------------enig29C776689EE13249618D14C6--