From: Richard Farina <sidhayn@gmail.com>
To: Alfonso Fiore <alfonso.fiore@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: compat-wireless can't compile under kernel 3.2.0 both 3.3-rc1-2 and 2012-01-26 - error: missing binary operator before token "("
Date: Tue, 31 Jan 2012 19:55:21 -0500 [thread overview]
Message-ID: <4F288D79.8040001@gmail.com> (raw)
In-Reply-To: <CAO=xpBFwEzTuidOMj02JPjV_mHyiqFpj-CE59Tw6kyqrocRSJA@mail.gmail.com>
On 01/31/12 19:32, Alfonso Fiore wrote:
> Hi John,
>
> thank you.
>
> sorry for jumping the gun, but I've been fighting various driver
> problems for weeks and now I feel so close...
>
> I tried to apply your patch and I imagine I did right since the error changed...
>
> I created a text file patch.txt and then from the folder of
> compat-wireless I did:
> patch -p1 < patch.txt
> patching file include/linux/compat-2.6.h (output)
>
> ---
> include/linux/compat-2.6.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/compat-2.6.h b/include/linux/compat-2.6.h
> index c23e94a..3ccd051 100644
> --- a/include/linux/compat-2.6.h
> +++ b/include/linux/compat-2.6.h
> @@ -2,7 +2,9 @@
> #define LINUX_26_COMPAT_H
>
> #include <linux/version.h>
> -#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33))
> +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,1,0))
> +#include <linux/kconfig.h>
> +#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,33))
> #include <generated/autoconf.h>
> #else
> #include <linux/autoconf.h>
> --
>
> but make still complains:
>
> compat-wireless-2012-01-26$ make
> ./scripts/gen-compat-autoconf.sh config.mk > include/linux/compat_autoconf.h
> make -C /lib/modules/3.2.0-interlaced2+/build
> M=/home/alfonso/wifi/compat-wireless-2012-01-26 modules
> make[1]: Entering directory `/home/alfonso/tests/kernel/linux_keithp'
> LD /home/alfonso/wifi/compat-wireless-2012-01-26/compat/built-in.o
> CC [M] /home/alfonso/wifi/compat-wireless-2012-01-26/compat/main.o
> In file included from
> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:40:0,
> from <command-line>:0:
> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-3.3.h:28:20:
> error: static declaration of âskb_complete_wifi_ackâ follows
> non-static declaration
> include/linux/skbuff.h:2260:6: note: previous declaration of
> âskb_complete_wifi_ackâ was here
> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-3.3.h:34:13:
> error: conflicting types for ânetdev_features_tâ
> include/linux/netdev_features.h:15:13: note: previous declaration of
> ânetdev_features_tâ was here
> make[3]: *** [/home/alfonso/wifi/compat-wireless-2012-01-26/compat/main.o]
> Error 1
> make[2]: *** [/home/alfonso/wifi/compat-wireless-2012-01-26/compat] Error 2
> make[1]: *** [_module_/home/alfonso/wifi/compat-wireless-2012-01-26] Error 2
> make[1]: Leaving directory `/home/alfonso/tests/kernel/linux_keithp'
> make: *** [modules] Error 2
>
> Did I do something wrong?
>
> thank you,
> alfonso
>
> On Wed, Feb 1, 2012 at 1:15 AM, John W. Linville <linville@tuxdriver.com> wrote:
>> Luis needs to apply "compat: use kconfig.h in compat-2.6.h for 3.1
>> and later kernels" that I posted earlier.
>>
>> John
>>
>> On Wed, Feb 01, 2012 at 01:06:01AM +0100, Alfonso Fiore wrote:
>>> Hi,
>>>
>>> I'm facing a bug you fixed in compat-wireless-3.3-rc1-2: rt2800pci:
>>> fix spurious interrupts generation
>>> But I must run a 3.2.0 kernel with some patches for my display driver
>>> (cause I'm greedy and I want both to see the screen and access
>>> internet)
>>>
>>> I tested in kernel 3.0.0 and I can compile and see the bug is fixed.
>>>
>>> but when I try to compile under 3.2.0 I get the following error:
>>>
>>> $ make
Did you remember to run "make clean" after applying the patch?
-Rick
>>> ./scripts/gen-compat-autoconf.sh config.mk > include/linux/compat_autoconf.h
>>> make -C /lib/modules/3.2.0-interlaced2+/build
>>> M=/home/alfonso/wifi/compat-wireless-2012-01-26 modules
>>> make[1]: Entering directory `/home/alfonso/tests/kernel/linux_keithp'
>>> LD /home/alfonso/wifi/compat-wireless-2012-01-26/compat/built-in.o
>>> CC [M] /home/alfonso/wifi/compat-wireless-2012-01-26/compat/main.o
>>> In file included from include/net/net_namespace.h:13:0,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/net/net_namespace.h:7,
>>> from include/linux/netdevice.h:49,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.29.h:5,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:24,
>>> from <command-line>:0:
>>> include/net/netns/mib.h:15:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/net/netns/mib.h:15:15: error: missing binary operator before token "("
>>> In file included from include/net/net_namespace.h:23:0,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/net/net_namespace.h:7,
>>> from include/linux/netdevice.h:49,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.29.h:5,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:24,
>>> from <command-line>:0:
>>> include/net/netns/xfrm.h:59:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/net/netns/xfrm.h:59:15: error: missing binary operator before token "("
>>> In file included from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/net/net_namespace.h:7:0,
>>> from include/linux/netdevice.h:49,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.29.h:5,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:24,
>>> from <command-line>:0:
>>> include/net/net_namespace.h:80:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/net/net_namespace.h:80:15: error: missing binary operator
>>> before token "("
>>> In file included from include/linux/netdevice.h:54:0,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.29.h:5,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:24,
>>> from <command-line>:0:
>>> include/net/netprio_cgroup.h: In function ātask_netprio_stateā:
>>> include/net/netprio_cgroup.h:44:5: warning: "IS_ENABLED" is not
>>> defined [-Wundef]
>>> include/net/netprio_cgroup.h:44:15: error: missing binary operator
>>> before token "("
>>> In file included from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.29.h:5:0,
>>> from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:24,
>>> from <command-line>:0:
>>> include/linux/netdevice.h: At top level:
>>> include/linux/netdevice.h:147:39: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:153:7: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:153:17: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:159:6: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:159:16: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:964:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:964:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:981:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:981:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:1123:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:1123:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:1126:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:1126:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:1289:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:1289:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h:1293:5: warning: "IS_ENABLED" is not defined [-Wundef]
>>> include/linux/netdevice.h:1293:15: error: missing binary operator
>>> before token "("
>>> include/linux/netdevice.h: In function ānetdev_uses_dsa_tagsā:
>>> include/linux/netdevice.h:1397:9: error: āstruct net_deviceā has no
>>> member named ādsa_ptrā
>>> include/linux/netdevice.h:1398:31: error: āstruct net_deviceā has no
>>> member named ādsa_ptrā
>>> include/linux/netdevice.h: In function ānetdev_uses_trailer_tagsā:
>>> include/linux/netdevice.h:1416:9: error: āstruct net_deviceā has no
>>> member named ādsa_ptrā
>>> include/linux/netdevice.h:1417:35: error: āstruct net_deviceā has no
>>> member named ādsa_ptrā
>>> In file included from
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-2.6.h:38:0,
>>> from <command-line>:0:
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-3.3.h:
>>> At top level:
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-3.3.h:28:20:
>>> error: static declaration of āskb_complete_wifi_ackā follows
>>> non-static declaration
>>> include/linux/skbuff.h:2260:6: note: previous declaration of
>>> āskb_complete_wifi_ackā was here
>>> /home/alfonso/wifi/compat-wireless-2012-01-26/include/linux/compat-3.3.h:34:13:
>>> error: conflicting types for ānetdev_features_tā
>>> include/linux/netdev_features.h:15:13: note: previous declaration of
>>> ānetdev_features_tā was here
>>> make[3]: *** [/home/alfonso/wifi/compat-wireless-2012-01-26/compat/main.o]
>>> Error 1
>>> make[2]: *** [/home/alfonso/wifi/compat-wireless-2012-01-26/compat] Error 2
>>> make[1]: *** [_module_/home/alfonso/wifi/compat-wireless-2012-01-26] Error 2
>>> make[1]: Leaving directory `/home/alfonso/tests/kernel/linux_keithp'
>>> make: *** [modules] Error 2
>>>
>>> Thank you for you help,
>>> alfonso
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> John W. Linville Someday the world will need a hero, and you
>> linville@tuxdriver.com might be all we have. Be ready.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-02-01 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 0:06 compat-wireless can't compile under kernel 3.2.0 both 3.3-rc1-2 and 2012-01-26 - error: missing binary operator before token "(" Alfonso Fiore
2012-02-01 0:15 ` John W. Linville
2012-02-01 0:32 ` Alfonso Fiore
2012-02-01 0:55 ` Richard Farina [this message]
2012-02-01 0:59 ` Alfonso Fiore
2012-09-05 10:58 ` compat-wireless can't compile under kernel 3.2.0 both 3.3-rc1-2 and 2012-01-26 - error: missing binary operator before token CHITRA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F288D79.8040001@gmail.com \
--to=sidhayn@gmail.com \
--cc=alfonso.fiore@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.