From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V1] gpio: tps65910: Add sleep control support Date: Wed, 1 Feb 2012 12:06:29 +0530 Message-ID: <4F28DD6D.9030606@nvidia.com> References: <1327999512-4935-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "jedu-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wednesday 01 February 2012 03:01 AM, Linus Walleij wrote: > On Tue, Jan 31, 2012 at 9:45 AM, Laxman Dewangan wrote: > >> The device tps65910/tps65911 supports the sleep >> functionality in some of gpios. If gpio is configured >> in output mode and sleep is enabled then during device >> sleep state, the output of gpio becomes LOW regardless >> of non-sleep output value. >> Such gpio can be used to control regulator switch such >> that output of regulator is off in device sleep state. >> >> Signed-off-by: Laxman Dewangan > Strictly speaking this is pin control business, but since it is already > doing other stuff like this from platform data why not... > > Comments: > Thanks for review. I have taken care of all your comments and will send another version with these changes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753724Ab2BAGho (ORCPT ); Wed, 1 Feb 2012 01:37:44 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:7294 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039Ab2BAGhm (ORCPT ); Wed, 1 Feb 2012 01:37:42 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 31 Jan 2012 22:37:35 -0800 Message-ID: <4F28DD6D.9030606@nvidia.com> Date: Wed, 1 Feb 2012 12:06:29 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Linus Walleij CC: "grant.likely@secretlab.ca" , "linus.walleij@stericsson.com" , "jedu@slimlogic.co.uk" , "lrg@slimlogic.co.uk" , "broonie@opensource.wolfsonmicro.com" , "sameo@linux.intel.com" , "gg@slimlogic.co.uk" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH V1] gpio: tps65910: Add sleep control support References: <1327999512-4935-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 01 February 2012 03:01 AM, Linus Walleij wrote: > On Tue, Jan 31, 2012 at 9:45 AM, Laxman Dewangan wrote: > >> The device tps65910/tps65911 supports the sleep >> functionality in some of gpios. If gpio is configured >> in output mode and sleep is enabled then during device >> sleep state, the output of gpio becomes LOW regardless >> of non-sleep output value. >> Such gpio can be used to control regulator switch such >> that output of regulator is off in device sleep state. >> >> Signed-off-by: Laxman Dewangan > Strictly speaking this is pin control business, but since it is already > doing other stuff like this from platform data why not... > > Comments: > Thanks for review. I have taken care of all your comments and will send another version with these changes.