Re: [PATCH 2/3] sysklogd: various fixes so it starts/stops cleanly

[Joshua Lock <josh@linux.intel.com>]

On 31/01/12 18:06, Otavio Salvador wrote:
> On Tue, Jan 31, 2012 at 22:58, Joshua Lock <josh@linux.intel.com
> <mailto:josh@linux.intel.com>> wrote:
>
>     @@ -46,12 +46,18 @@ do_install () {
>       pkg_preinst_${PN} () {
>             # all this is needed to avoid sysmlink errors,
>             # because update-rc.d runs before pkg_postinst
>     -       if [ -e ${sysconfdir}/init.d/syslog -a ! -L
>     ${sysconfdir}/init.d/syslog ]; then
>     +       if test "x$D" != "x"; then
>     +               ETC=$D/${sysconfdir}
>     +       else
>     +               ETC=${sysconfdir}
>     +       fi
>
>
> You might use
>
> ETC=$D${sysconfdir}
>
> and avoid the if block as a whole.

Quite right. That is cleaner, updated commit pushed to the same branch:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=josh/fixes&id=937acf5b59e5a1de2cc334b069390b3ccdb055a0

Thanks for the review.

Cheers,
Joshua
-- 
Joshua Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre