From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev Date: Wed, 01 Feb 2012 08:29:51 +0100 Message-ID: <4F28E9EF.9000706@redhat.com> References: <4F2853EA.3030808@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Anthony Liguori , qemu-devel , Blue Swirl , Marcelo Tosatti , Avi Kivity , kvm To: Anthony Liguori Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:44897 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216Ab2BAH36 (ORCPT ); Wed, 1 Feb 2012 02:29:58 -0500 Received: by pbdu11 with SMTP id u11so851840pbd.19 for ; Tue, 31 Jan 2012 23:29:58 -0800 (PST) In-Reply-To: <4F2853EA.3030808@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 01/31/2012 09:49 PM, Anthony Liguori wrote: >> >> + DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1), >> + DEFINE_PROP_PTR("pit", PCSpkState, pit), > > Please don't introduce a pointer property here. They cannot be used in > a meaningful way in qdev. Why not register a link in > instance_init? I'm going to clean this up, you can leave the PTR for now. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsUdq-00083C-FM for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:30:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RsUdj-0006wh-Ti for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:30:05 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:46953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RsUdj-0006vp-Mm for qemu-devel@nongnu.org; Wed, 01 Feb 2012 02:29:59 -0500 Received: by dadp14 with SMTP id p14so805356dad.4 for ; Tue, 31 Jan 2012 23:29:58 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F28E9EF.9000706@redhat.com> Date: Wed, 01 Feb 2012 08:29:51 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4F2853EA.3030808@codemonkey.ws> In-Reply-To: <4F2853EA.3030808@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , kvm , Jan Kiszka , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity On 01/31/2012 09:49 PM, Anthony Liguori wrote: >> >> + DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1), >> + DEFINE_PROP_PTR("pit", PCSpkState, pit), > > Please don't introduce a pointer property here. They cannot be used in > a meaningful way in qdev. Why not register a link in > instance_init? I'm going to clean this up, you can leave the PTR for now. Paolo