From: Kazuya Mio <k-mio@sx.jp.nec.com>
To: Jan Kara <jack@suse.cz>
Cc: ext4 <linux-ext4@vger.kernel.org>, Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH 2/2] ext3: Don't update ctime in ext3_splice_branch()
Date: Wed, 01 Feb 2012 16:56:17 +0900 [thread overview]
Message-ID: <4F28F021.8030904@sx.jp.nec.com> (raw)
In-Reply-To: <20120130175217.GA7827@quack.suse.cz>
2012/01/31 2:52, Jan Kara wrote:
> Thanks for the patches. This is true for ordinary writes but not true
> when you write via mmap. We call file_update_time() during page fault so
> ctime won't be completely wrong but still we should update it after block
> is allocated during writeback to reflect that new block is allocated to
> the inode.
Should we update ctime whenever a block is allocated?
If so, ordinary write in ext4 with indirect block mapping has the same problem
due to the following patch, right?
http://marc.info/?l=linux-ext4&m=124505184027078&w=4
Regards,
Kazuya Mio
next prev parent reply other threads:[~2012-02-01 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 8:41 [PATCH 2/2] ext3: Don't update ctime in ext3_splice_branch() Kazuya Mio
2012-01-30 17:52 ` Jan Kara
2012-02-01 7:56 ` Kazuya Mio [this message]
2012-02-01 10:46 ` Jan Kara
2012-02-08 8:36 ` Kazuya Mio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F28F021.8030904@sx.jp.nec.com \
--to=k-mio@sx.jp.nec.com \
--cc=adilger@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.