From: "Stephan Bärwolf" <stephan.baerwolf@tu-ilmenau.de>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests
Date: Wed, 01 Feb 2012 11:45:41 +0100 [thread overview]
Message-ID: <4F2917D5.2040203@tu-ilmenau.de> (raw)
In-Reply-To: <1328092020-18511-1-git-send-email-avi@redhat.com>
On 02/01/12 11:27, Avi Kivity wrote:
>
> +static bool vendor_intel(struct x86_emulate_ctxt *ctxt)
> +{
> + u32 eax, ebx, ecx, edx;
Just to be clean:
Shouldn't eax and ecx be initialized to zero?
regards Stephan
> +
> + return ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx)
> + && ebx == X86EMUL_CPUID_VENDOR_GenuineIntel_ebx
> + && ecx == X86EMUL_CPUID_VENDOR_GenuineIntel_ecx
> + && edx == X86EMUL_CPUID_VENDOR_GenuineIntel_edx;
> +}
> +
next prev parent reply other threads:[~2012-02-01 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 10:27 [PATCH] KVM: x86 emulator: reject SYSENTER in compatibility mode on AMD guests Avi Kivity
2012-02-01 10:45 ` Stephan Bärwolf [this message]
2012-02-01 10:50 ` Avi Kivity
2012-02-01 10:59 ` Stephan Bärwolf
2012-02-01 11:03 ` Avi Kivity
2012-02-01 11:00 ` Marcelo Tosatti
2012-02-01 13:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2917D5.2040203@tu-ilmenau.de \
--to=stephan.baerwolf@tu-ilmenau.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.