From: Paolo Bonzini <pbonzini@redhat.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse
Date: Wed, 01 Feb 2012 13:23:45 +0100 [thread overview]
Message-ID: <4F292ED1.3060901@redhat.com> (raw)
In-Reply-To: <4F2861F4.1000604@web.de>
On 01/31/2012 10:49 PM, Jan Kiszka wrote:
> > Just make the methods that you want to override virtual with the default
> > implementation and then make a KVMPIT that inherits from the PIT and
> > then overrides whatever virtual functions it needs to.
>
> That doesn't sound like the proper design for this purpose. Rather, we
> have an abstract base class that both implementations are derived from.
Absolutely!
> If I'm not using QOM properly to achieve this, please tell me.
It looks good, besides the need to rebase to Anthony's "part 3" changes.
Paolo
next prev parent reply other threads:[~2012-02-01 12:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 18:46 [PATCH 0/4] uq/master: Introduce KVM PIT support Jan Kiszka
2012-01-31 18:46 ` [Qemu-devel] " Jan Kiszka
2012-01-31 18:46 ` [PATCH 1/4] i8254: Factor out base class for KVM reuse Jan Kiszka
2012-01-31 18:46 ` [Qemu-devel] " Jan Kiszka
2012-01-31 21:40 ` Anthony Liguori
2012-01-31 21:40 ` Anthony Liguori
2012-01-31 21:49 ` Jan Kiszka
2012-01-31 21:49 ` Jan Kiszka
2012-01-31 21:59 ` Anthony Liguori
2012-01-31 21:59 ` [Qemu-devel] " Anthony Liguori
2012-02-01 12:23 ` Paolo Bonzini [this message]
2012-02-01 12:43 ` Jan Kiszka
2012-02-01 12:43 ` [Qemu-devel] " Jan Kiszka
2012-02-01 12:55 ` Paolo Bonzini
2012-02-01 12:55 ` Paolo Bonzini
2012-02-01 13:10 ` Jan Kiszka
2012-02-01 13:10 ` Jan Kiszka
2012-02-01 13:11 ` Jan Kiszka
2012-02-01 13:11 ` Jan Kiszka
2012-02-01 13:19 ` Anthony Liguori
2012-02-01 13:19 ` [Qemu-devel] " Anthony Liguori
2012-01-31 18:46 ` [PATCH 2/4] i8254: Open-code timer restore Jan Kiszka
2012-01-31 18:46 ` [Qemu-devel] " Jan Kiszka
2012-01-31 18:46 ` [PATCH 3/4] kvm: Add kvm_has_pit_state2 helper Jan Kiszka
2012-01-31 18:46 ` [Qemu-devel] " Jan Kiszka
2012-01-31 18:46 ` [PATCH 4/4] kvm: x86: Add user space part for in-kernel i8254 Jan Kiszka
2012-01-31 18:46 ` [Qemu-devel] " Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2012-02-05 10:46 [PATCH 0/4] uq/master: Introduce KVM PIT support Jan Kiszka
2012-02-05 10:46 ` [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F292ED1.3060901@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.