From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 1/1] osd_uld: Bump MAX_OSD_DEVICES from 64 to 1,048,576 Date: Wed, 1 Feb 2012 17:50:30 +0200 Message-ID: <4F295F46.2010106@panasas.com> References: <4F205AAF.7000305@panasas.com> <4F205B42.9020200@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from natasha.panasas.com ([67.152.220.90]:41228 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754852Ab2BAPux (ORCPT ); Wed, 1 Feb 2012 10:50:53 -0500 In-Reply-To: <4F205B42.9020200@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi , open-osd , linux-fsdevel , Al Viro , Andrew Morton , "Welch, Brent" , "Bhamare, Sachin" , Stable Tree On 01/25/2012 09:42 PM, Boaz Harrosh wrote: > > It used to be that minors where 8 bit. But now they > are actually 20 bit. So the fix is simplicity itself. > > I've tested with 300 devices and all user-mode utils > work just fine. I have also mechanically added 10,000 > to the ida (so devices are /dev/osd10000, /dev/osd10001 ...) > and was able to mkfs an exofs filesystem and access osds > from user-mode. > > All the open-osd user-mode code uses the same library > to access devices through their symbolic names in > /dev/osdX so I'd say it's pretty safe. (Well tested) > > This patch is very important because some of the systems > that will be deploying the 3.2 pnfs-objects code are larger > than 64 OSDs and will stop to work properly when reaching > that number. > > CC: Stable > Signed-off-by: Boaz Harrosh James Hi You never came back to me on this patch. It is very important for the setups all this osd stuff is intended for. It is a simple bug right in the middle of the system, which makes it useless. (I'm so embarrassed I made it in the first place) I have put it in today's linux-next, so it can collect dust there. Please tell me if you want to carry this for this rc-fixes or I should push it through the osd tree. Thanks Boaz > --- > drivers/scsi/osd/osd_uld.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c > index b31a8e3..d4ed9eb 100644 > --- a/drivers/scsi/osd/osd_uld.c > +++ b/drivers/scsi/osd/osd_uld.c > @@ -69,10 +69,10 @@ > #ifndef SCSI_OSD_MAJOR > # define SCSI_OSD_MAJOR 260 > #endif > -#define SCSI_OSD_MAX_MINOR 64 > +#define SCSI_OSD_MAX_MINOR MINORMASK > > static const char osd_name[] = "osd"; > -static const char *osd_version_string = "open-osd 0.2.0"; > +static const char *osd_version_string = "open-osd 0.2.1"; > > MODULE_AUTHOR("Boaz Harrosh "); > MODULE_DESCRIPTION("open-osd Upper-Layer-Driver osd.ko");