Re: [PATCH v4] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

On 02/01/2012 04:55 PM, Stephane Grosjean wrote:
> Le 01/02/2012 16:48, Marc Kleine-Budde a écrit :
>> #if defined(CONFIG_I2C_ALGOBIT) || defined(CONFIG_I2C_ALGOBIT_MODULE)
>> #define peak_pci_support_pcie()    (1)
>> #else
>> #define peak_pci_support_pcie()    (0)
>> #endif
>>
>> In the probe function you can write:
>>
>> probe() {
>>     ...
>>
>>     if (peak_pci_support_pcie()&&
>>     pdev->device == PEAK_PCIEC_DEVICE_ID) {
>>         ...
>>     }
>> }
>>
>> There should be no ifdefs left in the code. One question remains, is the
>> i2c core clever enough to define no-ops if the i2c subsystem is switched
>> off?
>> I just tried - :( - it doesn't work
>>
>> drivers/net/can/sja1000/peak_pci.c: In function
>> 'peak_pciec_write_pca9553':
>> drivers/net/can/sja1000/peak_pci.c:267: error: implicit declaration of
>> function 'i2c_transfer'
>> drivers/net/can/sja1000/peak_pci.c: In function 'peak_pciec_init':
>> drivers/net/can/sja1000/peak_pci.c:491: error: implicit declaration of
>> function 'i2c_del_adapter'
>>
>> Marc
> 
> What about that:
> 
>> #if defined(CONFIG_I2C_ALGOBIT) || defined(CONFIG_I2C_ALGOBIT_MODULE)
>> #define peak_pci_support_pcie()    (1)
>> #else
>> #define peak_pci_support_pcie()    (0)
> #define i2_transfer(a, b, c)
> #define i2c_del_adapter(a)
>> #endif

This is an option, please make it static inline function, to have
typechecking.

Wolfgang, what do you think?

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]