All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 01/15] legal-info: new target to echo basic per-package legal info
Date: Wed, 01 Feb 2012 22:07:17 +0100	[thread overview]
Message-ID: <4F29A985.3070807@lucaceresoli.net> (raw)
In-Reply-To: <201201311815.51660.arnout@mind.be>

Hi Arnout,
thanks for the review.

Arnout Vandecappelle wrote:
> On Sunday 29 January 2012 16:11:34 Luca Ceresoli wrote:
>> Signed-off-by: Luca Ceresoli<luca@lucaceresoli.net>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
>
>> ---
>>   Makefile                    |    9 ++++++++-
>>   package/Makefile.package.in |    6 ++++++
>>   2 files changed, 14 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 912012f..507fd78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -354,6 +354,11 @@ HOST_DEPS = $(sort $(foreach dep,\
>>   		$($(dep))))
>>   HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
>>
>> +TARGETS_LEGAL_INFO:=$(patsubst %,%-legal-info,\
>> +		$(filter-out makedevs,\
>> +		$(patsubst host-%,%,\
>> +		$(TARGETS) $(BASE_TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
>> +
>   Are we creating the legal info of the target or the SDK here?  If it is
> for the target, the host-% are not needed since they are not distributed.
> I think there should be a separate command for the SDK's legal info.

The intent was to save also the SDK (toolchain), except it does not
currently work.
But this raises a more high-level question about what we want to save
here: target packages, host packages (toolchain and others), BR sources,
BR .config? I think the right answer is "all of them", but I've put it
on my list of issues to be discussed in the BDD.

>
> [snip]
>> +$(1)-legal-info:	$(1)-source
>> +			@echo -e "$(1)\t$$($(3)_VERSION)\t$$($(3)_LICENSE)"
>> +
>   Minor detail: if this patch is separate from the one that saves the source
> tarball, the dependency on $(1)-source is unnecessary.

Ops, this is the result of the massive rebases I did before posting.
Moved to the right patch, thanks.

Luca

  reply	other threads:[~2012-02-01 21:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29 15:11 [Buildroot] [RFC 00/15] Automatically produce legal compliance info Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 01/15] legal-info: new target to echo basic per-package legal info Luca Ceresoli
2012-01-31 17:15   ` Arnout Vandecappelle
2012-02-01 21:07     ` Luca Ceresoli [this message]
2012-01-29 15:11 ` [Buildroot] [RFC 02/15] legal-info: produce a manifest file with licensing info Luca Ceresoli
2012-01-31 17:25   ` Arnout Vandecappelle
2012-02-01 21:29     ` Luca Ceresoli
2012-02-01 22:15       ` Thomas Petazzoni
2012-02-02  7:41       ` Thomas De Schampheleire
2012-01-29 15:11 ` [Buildroot] [RFC 03/15] legal-info: save source tarballs for all packages Luca Ceresoli
2012-01-31 22:10   ` Arnout Vandecappelle
2012-02-01 21:38     ` Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 04/15] legal-info: do not copy sources for proprietary packages Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 05/15] mpc: define license Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 06/15] linux: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 07/15] m4: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 08/15] busybox: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 09/15] bzip2: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 10/15] directfb: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 11/15] iostat: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 12/15] lzop: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 13/15] tslib: " Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 14/15] foobar: create a fake proprietary package (testing only) Luca Ceresoli
2012-01-29 15:26   ` Diego Iastrubni
2012-01-29 15:50     ` Michael S. Zick
2012-01-29 16:08       ` Diego Iastrubni
2012-01-30 11:51       ` Luca Ceresoli
2012-01-29 15:11 ` [Buildroot] [RFC 15/15] Create a test config " Luca Ceresoli
2012-01-31  7:15 ` [Buildroot] [RFC 00/15] Automatically produce legal compliance info Arnout Vandecappelle
2012-01-31 22:27 ` Yann E. MORIN
2012-02-01 15:25   ` Thomas De Schampheleire
2012-02-01 21:47     ` Luca Ceresoli
2012-02-02  8:32       ` Thomas De Schampheleire
2012-02-02  9:27         ` Luca Ceresoli
2012-02-02 11:19           ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F29A985.3070807@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.