diff for duplicates of <4F29AE8B.2020600@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 08ef47e..9b18e29 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ On 02/01/2012 04:24 PM, Andrew Morton wrote: >> same. >> >> My patch temporarily broke things, by testing for order< 0, ->> instead of the explicit cc->order = -1 used elsewhere in +>> instead of the explicit cc->order == -1 used elsewhere in >> the code. >> >> I did not notice it in my own testing because I tested on @@ -30,7 +30,7 @@ On 02/01/2012 04:24 PM, Andrew Morton wrote: >> >> In my test tree, I had (cc->sync || !compaction_deferred(zone, cc->order)). >> ->> Arguably, testing for cc->order = -1 (or cc->order< 0) is +>> Arguably, testing for cc->order == -1 (or cc->order< 0) is >> better anyway. > > I suppose it would be nicer to make the code in __compact_pgdat() match @@ -43,7 +43,7 @@ On 02/01/2012 04:24 PM, Andrew Morton wrote: > INIT_LIST_HEAD(&cc->migratepages); > > - if (cc->order< 0 || !compaction_deferred(zone, cc->order)) -> + if (cc->order = -1 || !compaction_deferred(zone, cc->order)) +> + if (cc->order == -1 || !compaction_deferred(zone, cc->order)) > compact_zone(zone, cc); > > if (cc->order> 0) { @@ -53,3 +53,10 @@ as expected. -- All rights reversed + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index a301316..d551914 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\020120201132415.b09d8710.akpm@linux-foundation.org\0" "From\0Rik van Riel <riel@redhat.com>\0" "Subject\0Re: [patch] mm: compaction: make compact_control order signed\0" - "Date\0Wed, 01 Feb 2012 21:28:43 +0000\0" + "Date\0Wed, 01 Feb 2012 16:28:43 -0500\0" "To\0Andrew Morton <akpm@linux-foundation.org>\0" "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" Mel Gorman <mel@csn.ul.ie> @@ -36,7 +36,7 @@ ">> same.\n" ">>\n" ">> My patch temporarily broke things, by testing for order< 0,\n" - ">> instead of the explicit cc->order = -1 used elsewhere in\n" + ">> instead of the explicit cc->order == -1 used elsewhere in\n" ">> the code.\n" ">>\n" ">> I did not notice it in my own testing because I tested on\n" @@ -46,7 +46,7 @@ ">>\n" ">> In my test tree, I had (cc->sync || !compaction_deferred(zone, cc->order)).\n" ">>\n" - ">> Arguably, testing for cc->order = -1 (or cc->order< 0) is\n" + ">> Arguably, testing for cc->order == -1 (or cc->order< 0) is\n" ">> better anyway.\n" ">\n" "> I suppose it would be nicer to make the code in __compact_pgdat() match\n" @@ -59,7 +59,7 @@ "> \t\tINIT_LIST_HEAD(&cc->migratepages);\n" ">\n" "> -\t\tif (cc->order< 0 || !compaction_deferred(zone, cc->order))\n" - "> +\t\tif (cc->order = -1 || !compaction_deferred(zone, cc->order))\n" + "> +\t\tif (cc->order == -1 || !compaction_deferred(zone, cc->order))\n" "> \t\t\tcompact_zone(zone, cc);\n" ">\n" "> \t\tif (cc->order> 0) {\n" @@ -68,6 +68,13 @@ "as expected.\n" "\n" "-- \n" - All rights reversed + "All rights reversed\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -de72ac7e821e172c7c92621ebf9b6c20894f2fcdb482600a277950523b1b6af8 +98436738100a4e4b498ac7f4ff30e44136c7bb1afda32ea15e08a5e7f5e9cd8c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.