From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Coopersmith Subject: Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-* Date: Wed, 01 Feb 2012 14:04:52 -0800 Message-ID: <4F29B704.2010106@oracle.com> References: <87boqgu5zf.fsf@eliezer.anholt.net> <87ehuj5l2n.fsf@eliezer.anholt.net> <5A68BEB0-7C83-4215-8A10-B5014060C764@freedesktop.org> <87fwex9mwp.fsf@eliezer.anholt.net> <20120201204316.GN19118@radis.cristau.org> <59101C6A-2C7E-47D0-BE89-0FAC63240533@freedesktop.org> <20120201215607.GO19118@radis.cristau.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120201215607.GO19118@radis.cristau.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Julien Cristau Cc: Jeremy Huddleston , dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch List-Id: dri-devel@lists.freedesktop.org On 02/ 1/12 01:56 PM, Julien Cristau wrote: > On Wed, Feb 1, 2012 at 13:01:58 -0800, Jeremy Huddleston wrote: > >> yeah, that's probably cleaner (I guess it'll avoid the -*), but it should have the same effect. >> > I get host_os=linux-gnu here afaict, so not really the same effect, no. Jeremy was probably thinking of $host, which has both the os & cpu in, but this was already fixed in libdrm git last night when people on IRC noticed that the Intel drm module stopped building on x86 systems. commit 82c6938d232327233caac743a07639ac91bceb7e Author: Paul Berry Date: Tue Jan 31 14:44:14 2012 -0800 intel: Fix build of Intel DRM on x86 systems Commit efd6e81e inadvertently broke the build by looking for "i?86" or "x86_64" in $host_os. The correct variable to check is $host_cpu. This was preventing libdrm_intel.so from being built. Reviewed-by: Chad Versace diff --git a/configure.ac b/configure.ac index f5ebc1d..b59bc54 100644 --- a/configure.ac +++ b/configure.ac @@ -250,8 +250,8 @@ if test "x$INTEL" != "xno" -o "x$RADEON" != "xno"; then else if test "x$INTEL" != "xno"; then - case $host_os in - i?86-*|x86_64-*) INTEL=yes ;; + case $host_cpu in + i?86|x86_64) INTEL=yes ;; *) INTEL=no ;; esac fi -- -Alan Coopersmith- alan.coopersmith@oracle.com Oracle Solaris Platform Engineering: X Window System