All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/7] arm, arm926ejs: Flush the data cache before disabling it
Date: Thu, 02 Feb 2012 07:34:58 +0100	[thread overview]
Message-ID: <4F2A2E92.1010007@denx.de> (raw)
In-Reply-To: <1328018214-6461-4-git-send-email-christian.riesch@omicron.at>

Hello Christian,

Christian Riesch wrote:
> From: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> The current implementation invalidates the data cache before turning it
> off and causes problems on the hawkboard. See the discussion in
> http://lists.denx.de/pipermail/u-boot/2012-January/115212.html
> 
> According to the ARM926EJ-S Technical Reference Manual, the cache should
> be flushed instead.
> 
> Also fix the comments to match code.
> 
> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> Rebased and corrected commit message.
> 
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> ---
>  arch/arm/cpu/arm926ejs/start.S |   12 ++++++++----
>  1 files changed, 8 insertions(+), 4 deletions(-)


Acked-by: Heiko Schocher <hs@denx.de>

Tested on the cam_enc_4xx and enbw_cmc board, so:

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2012-02-02  6:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31 13:56 [U-Boot] [PATCH v5 0/7] Change ARM926EJ-S startup code, hawkboard and calimain Christian Riesch
2012-01-31 13:56 ` [U-Boot] [PATCH v5 1/7] arm, davinci: Add lowlevel_init for SoCs other than DM644X Christian Riesch
2012-02-02  6:34   ` Heiko Schocher
2012-01-31 13:56 ` [U-Boot] [PATCH v5 2/7] arm, arm926ejs: Do cpu critical inits only for boards that require it Christian Riesch
2012-02-02  6:34   ` Heiko Schocher
2012-01-31 13:56 ` [U-Boot] [PATCH v5 3/7] arm, arm926ejs: Flush the data cache before disabling it Christian Riesch
2012-02-02  6:34   ` Heiko Schocher [this message]
2012-01-31 13:56 ` [U-Boot] [PATCH v5 4/7] arm, arm926ejs: Do not clear the V bit on DA850 SoCs Christian Riesch
2012-01-31 17:52   ` Sughosh Ganu
2012-02-01  7:33     ` Heiko Schocher
2012-02-02  9:30       ` Christian Riesch
2012-02-02  9:34         ` Heiko Schocher
2012-02-02  6:35   ` Heiko Schocher
2012-01-31 13:56 ` [U-Boot] [PATCH v5 5/7] arm, arm926ejs: Enable icache only if CONFIG_SYS_ICACHE_OFF is not defined Christian Riesch
2012-02-02  6:35   ` Heiko Schocher
2012-01-31 13:56 ` [U-Boot] [PATCH v5 6/7] Changes to move hawkboard to the new spl infrastructure Christian Riesch
2012-01-31 13:56 ` [U-Boot] [PATCH v5 7/7] arm, davinci: Add support for the Calimain board from OMICRON electronics Christian Riesch
2012-02-01 15:17 ` [U-Boot] [PATCH v5 0/7] Change ARM926EJ-S startup code, hawkboard and calimain Sughosh Ganu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2A2E92.1010007@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.