From: Cong Wang <xiyou.wangcong@gmail.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Young <dyoung@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] move vm tools from Documentation/vm/ to tools/
Date: Thu, 02 Feb 2012 15:32:55 +0800 [thread overview]
Message-ID: <4F2A3C27.5080504@gmail.com> (raw)
In-Reply-To: <CABqxG0fyH89YP+jpZ5nJoVfzOQ++J4EfGP42FtjxAv7OY9o+5w@mail.gmail.com>
On 02/02/2012 10:13 AM, Dave Young wrote:
> On Thu, Feb 2, 2012 at 5:17 AM, Andrew Morton<akpm@linux-foundation.org> wrote:
>> On Wed, 1 Feb 2012 14:34:20 +0800
>> Dave Young<dyoung@redhat.com> wrote:
>>
>>> tools/ is the better place for vm tools which are used by many people.
>>> Moving them to tools also make them open to more users instead of hide in
>>> Documentation folder.
>>>
>>
>> It would be nice to covert these into simple pass/fail tests and
>> promote them to tools/testing/selftests/.
>
> Andrew, I'm not clear about this, do you means to selftest
> hugepage-mmap.c, hugepage-shm.c and map_hugetlb.c? I think slabinfo
> and page-types should stay in tools/vm/. Can you explain a bit?
>
Hey,
Check the comments in these files:
/*
* hugepage-mmap:
*
* Example of using huge page memory in a user application using the mmap
* system call.
/*
* hugepage-shm:
*
* Example of using huge page memory in a user application using Sys V
shared
* memory system calls. In this example the app is requesting 256MB of
* memory that is backed by huge pages. The application uses the flag
* SHM_HUGETLB in the shmget system call to inform the kernel that it is
* requesting huge pages.
/*
* Example of using hugepage memory in a user application using the mmap
* system call with MAP_HUGETLB flag.
All of them are examples, not tests, not tools, thus Documentation/ is
the best place for them.
next prev parent reply other threads:[~2012-02-02 7:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:34 [PATCH] move vm tools from Documentation/vm/ to tools/ Dave Young
2012-02-01 6:45 ` Cong Wang
2012-02-01 7:39 ` Dave Young
2012-02-01 7:32 ` Pekka Enberg
2012-02-01 7:32 ` Pekka Enberg
2012-02-01 7:41 ` Dave Young
2012-02-01 7:41 ` Dave Young
2012-02-01 8:30 ` Wu Fengguang
2012-02-01 8:30 ` Wu Fengguang
2012-02-01 8:44 ` Pekka Enberg
2012-02-01 8:44 ` Pekka Enberg
2012-02-01 9:53 ` Dave Young
2012-02-01 9:53 ` Dave Young
2012-02-01 9:53 ` Dave Young
2012-02-01 9:53 ` Dave Young
2012-02-01 14:40 ` Christoph Lameter
2012-02-01 14:40 ` Christoph Lameter
2012-02-01 21:17 ` Andrew Morton
2012-02-02 2:13 ` Dave Young
2012-02-02 7:32 ` Cong Wang [this message]
2012-02-02 19:58 ` Andrew Morton
2012-02-02 19:56 ` Andrew Morton
2012-02-03 1:31 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2A3C27.5080504@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.