From: Jens Axboe <jaxboe@fusionio.com>
To: Steven Lang <tirea@google.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] Optimize pattern filling by limiting small calls to memcpy.
Date: Thu, 2 Feb 2012 20:20:16 +0100 [thread overview]
Message-ID: <4F2AE1F0.9080005@fusionio.com> (raw)
In-Reply-To: <CAAUT-yMkot3gGYA13bwbakmMArsHYnF_bYOFNzW9sHDL2Eg+rA@mail.gmail.com>
On 2012-02-02 20:11, Steven Lang wrote:
> No, that's actually all of it; it's really that simple. It just takes
> the pattern buffer, and replicates it until it it is at least half
> full, which during verification drastically reduces the number of
> calls to memcpy() for short multibyte patterns.
Ah gotcha, I see what you mean now, what I missed was the assignment of
td->o.verify_pattern_bytes _after_ the extra fill on option init. Looks
good! I'll apply it.
--
Jens Axboe
prev parent reply other threads:[~2012-02-02 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 1:39 [PATCH] Optimize pattern filling by limiting small calls to memcpy Steven Lang
2012-02-02 8:48 ` Jens Axboe
2012-02-02 19:11 ` Steven Lang
2012-02-02 19:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2AE1F0.9080005@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=fio@vger.kernel.org \
--cc=tirea@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.