From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt2Gm-00054d-I5 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 14:24:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rt2Gh-0002b2-J2 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 14:24:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39240 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rt2Gh-0002aq-D3 for qemu-devel@nongnu.org; Thu, 02 Feb 2012 14:24:27 -0500 Message-ID: <4F2AE250.9020808@suse.de> Date: Thu, 02 Feb 2012 20:21:52 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-5-git-send-email-pbonzini@redhat.com> <4F2ADEB0.6090308@codemonkey.ws> In-Reply-To: <4F2ADEB0.6090308@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 02.02.2012 20:06, schrieb Anthony Liguori: > On 02/02/2012 10:45 AM, Paolo Bonzini wrote: >> Move the creation of QmpInputVisitor and QmpOutputVisitor from >> qmp.c to qom/object.c, since it's the only practical way to access >> object properties. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/qemu/object.h | 24 ++++++++++++++++++++++++ >> qmp.c | 17 ++--------------- >> qom/object.c | 29 +++++++++++++++++++++++++++++ >> 3 files changed, 55 insertions(+), 15 deletions(-) >=20 > I don't want object.h to have a dependency on QObject. We need to phas= e > out QObject. We did get that dependency though by your move of the property code to object.c. As you will see shortly, we now need qobject-obj-y and qapi-obj-y plus some stubs to make the user emulators compile with QOM. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg