From: Anthony Liguori <anthony@codemonkey.ws>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers
Date: Thu, 02 Feb 2012 14:58:34 -0600 [thread overview]
Message-ID: <4F2AF8FA.4060000@codemonkey.ws> (raw)
In-Reply-To: <4F2AE250.9020808@suse.de>
On 02/02/2012 01:21 PM, Andreas Färber wrote:
> Am 02.02.2012 20:06, schrieb Anthony Liguori:
>> On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
>>> Move the creation of QmpInputVisitor and QmpOutputVisitor from
>>> qmp.c to qom/object.c, since it's the only practical way to access
>>> object properties.
>>>
>>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>>> ---
>>> include/qemu/object.h | 24 ++++++++++++++++++++++++
>>> qmp.c | 17 ++---------------
>>> qom/object.c | 29 +++++++++++++++++++++++++++++
>>> 3 files changed, 55 insertions(+), 15 deletions(-)
>>
>> I don't want object.h to have a dependency on QObject. We need to phase
>> out QObject.
>
> We did get that dependency though by your move of the property code to
> object.c. As you will see shortly, we now need qobject-obj-y and
> qapi-obj-y plus some stubs to make the user emulators compile with QOM.
>
That's an implementation detail of Error, that's not because QObject is used
anywhere in QOM.
Regards,
Anthony Liguori
> Andreas
>
next prev parent reply other threads:[~2012-02-02 20:58 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:45 [Qemu-devel] [PATCH 00/16] access qdev properties via QOM Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 01/16] qdev: fix hot-unplug Paolo Bonzini
2012-02-02 17:03 ` Anthony Liguori
2012-02-02 17:29 ` Paolo Bonzini
2012-02-02 19:01 ` Anthony Liguori
2012-02-02 19:07 ` Alexander Graf
2012-02-02 20:03 ` Anthony Liguori
2012-02-02 20:31 ` Alexander Graf
2012-02-03 16:37 ` Anthony Liguori
2012-02-03 16:57 ` Alexander Graf
2012-02-03 17:12 ` Anthony Liguori
2012-02-03 14:27 ` Anthony Liguori
2012-02-04 0:27 ` Paolo Bonzini
2012-02-04 3:03 ` Anthony Liguori
2012-02-04 6:51 ` Paolo Bonzini
2012-02-04 17:13 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 02/16] qom: store object with correct type in interface links Paolo Bonzini
2012-02-02 17:05 ` Anthony Liguori
2012-02-03 12:10 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 03/16] qom: do not include qdev header file Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers Paolo Bonzini
2012-02-02 19:06 ` Anthony Liguori
2012-02-02 19:21 ` Andreas Färber
2012-02-02 20:58 ` Anthony Liguori [this message]
2012-02-02 19:24 ` Paolo Bonzini
2012-02-02 19:29 ` Paolo Bonzini
2012-02-02 20:01 ` Anthony Liguori
2012-02-02 19:36 ` Anthony Liguori
2012-02-02 20:08 ` Paolo Bonzini
2012-02-02 20:59 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 05/16] qom: add property get/set wrappers for C types Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 06/16] qdev: remove direct calls to print/parse Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 07/16] qdev: allow reusing get/set for legacy property Paolo Bonzini
2012-02-02 22:38 ` Andreas Färber
2012-02-03 8:11 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 08/16] qdev: remove parse method for string properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 09/16] qdev: remove parse/print methods for mac properties Paolo Bonzini
2012-02-02 20:05 ` Anthony Liguori
2012-02-02 16:45 ` [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer Paolo Bonzini
2012-02-02 20:07 ` Anthony Liguori
2012-02-02 20:19 ` Paolo Bonzini
2012-02-03 14:14 ` Anthony Liguori
2012-02-04 0:21 ` Paolo Bonzini
2012-02-04 0:43 ` Paolo Bonzini
2012-02-04 3:00 ` Anthony Liguori
2012-02-04 6:42 ` Paolo Bonzini
2012-02-04 7:13 ` Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 11/16] qdev: remove parse/print methods for pointer properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 12/16] qdev: let QOM free properties Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 13/16] qdev: fix off-by-one Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 14/16] qdev: access properties via QOM Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 15/16] qdev: inline qdev_prop_set into qdev_prop_set_ptr Paolo Bonzini
2012-02-02 16:45 ` [Qemu-devel] [PATCH 16/16] qdev: initialize properties via QOM Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2AF8FA.4060000@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.