From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Date: Fri, 03 Feb 2012 11:19:04 +0100 Message-ID: <4F2BB498.60606@grandegger.com> References: <1328188792-2982-1-git-send-email-s.grosjean@peak-system.com> <4F2ACFE9.3080602@hartkopp.net> <4F2B16F9.8020903@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ngcobalt02.manitu.net ([217.11.48.102]:49422 "EHLO ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406Ab2BCKTH (ORCPT ); Fri, 3 Feb 2012 05:19:07 -0500 In-Reply-To: <4F2B16F9.8020903@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp Cc: Stephane Grosjean , linux-can Mailing List On 02/03/2012 12:06 AM, Oliver Hartkopp wrote: > On 02.02.2012 19:03, Oliver Hartkopp wrote: > >> Hello Stephane et.al. >> >> On 02.02.2012 14:19, Stephane Grosjean wrote: >> >>> >>> config CAN_PEAK_PCI >>> - tristate "PEAK PCAN PCI/PCIe Cards" >>> + tristate "PEAK PCAN-PCI/PCIe/PCIeC/miniPCI Cards" >>> depends on PCI >>> ---help--- >>> - This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels) >>> - from PEAK Systems (http://www.peak-system.com). >>> + This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards >>> + (1, 2, 3 or 4 channels) from PEAK-System Technik >>> + (http://www.peak-system.com). >>> + >>> + The I2C bit-banging algorithm should be selected to enable >>> + correct LEDs management on the PCAN-ExpressCard (PCIeC) card. >> >> >> The problem is that the PCAN-ExpressCards without galvanic isolation >> (IPEH-003000, IPEH-003001) are not working at all when the I2C stuff is not >> initialized. If that is true... >> >> It's not only the LED handling. >> >> What about this: >> >> config CAN_PEAK_PCI >> tristate "PEAK PCAN-PCI/PCIe/miniPCI Cards" >> depends on PCI >> ---help--- >> This driver is for the PCAN PCI/PCIe cards (1, 2, 3 or 4 channels) >> from PEAK Systems (http://www.peak-system.com). >> This driver is for the PCAN-PCI/PCIe/PCIeC/miniPCI cards >> (1, 2, 3 or 4 channels) from PEAK-System Technik >> (http://www.peak-system.com). >> >> The I2C bit-banging algorithm (I2C ALGOBIT) needs to be selected to >> support PCAN-ExpressCard (PCIeC) cards. >> >> config CAN_PEAK_PCIEC >> tristate "PEAK PCAN-Express Cards" >> depends on CAN_PEAK_PCI && CONFIG_I2C_ALGOBIT > > > ... sorry : of course without CONFIG_ > > just > > config CAN_PEAK_PCIEC > bool "PEAK PCAN-Express Cards" > depends on CAN_PEAK_PCI && I2C_ALGOBIT > default y > > >> ---help--- > >> (bla bla) ... I definitely prefer that solution. It's more transparent and it also allows to drop support for the PCIEC on embedded boards if there is no PCI express slot. Furthermore, it does require little modifications to the v4.3 patch. Wolfgang.