From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1RtGHa-00068t-4E for mharc-grub-devel@gnu.org; Fri, 03 Feb 2012 05:22:18 -0500 Received: from eggs.gnu.org ([140.186.70.92]:47656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtGHT-00067M-EM for grub-devel@gnu.org; Fri, 03 Feb 2012 05:22:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtGHN-00055Q-0U for grub-devel@gnu.org; Fri, 03 Feb 2012 05:22:11 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:59566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtGHM-00055K-Pt for grub-devel@gnu.org; Fri, 03 Feb 2012 05:22:04 -0500 Received: by wibhj13 with SMTP id hj13so3506742wib.0 for ; Fri, 03 Feb 2012 02:22:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=uNy7QV/MVPmPzucxYaSkpcWn55Y+FtrN9GzhySwW/Ps=; b=XbHWds593IPm34IT/CS2ntkql7zs/glpx3V+0GtWhwmSm262xzXCKlIh9AeNoFmPsw 6+daHTs+6bLKWkpxt5Ft8eMj32aR7jdN6t8VryhGSXSY0X0GbtP+XKQVKJN+aFR18Zp6 lRqbpwDJkTrYN9EcOpT/sVWG5UsGUdaMa2EIY= Received: by 10.180.24.7 with SMTP id q7mr10457274wif.14.1328264524096; Fri, 03 Feb 2012 02:22:04 -0800 (PST) Received: from debian.x201.phnet (180-34.203-62.cust.bluewin.ch. [62.203.34.180]) by mx.google.com with ESMTPS id t6sm5538200wid.1.2012.02.03.02.22.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Feb 2012 02:22:03 -0800 (PST) Message-ID: <4F2BB548.5010106@gmail.com> Date: Fri, 03 Feb 2012 11:22:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120104 Icedove/8.0 MIME-Version: 1.0 To: Richard Laager Subject: Re: [PATCH] Don't create grubenv on ZFS References: <1328181390.3572.74.camel@watermelon.coderich.net> <4F2BB14C.8040207@gmail.com> <1328263657.17279.16.camel@watermelon.coderich.net> In-Reply-To: <1328263657.17279.16.camel@watermelon.coderich.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.169 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 10:22:17 -0000 On 03.02.2012 11:07, Richard Laager wrote: > On Fri, 2012-02-03 at 11:05 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >> On 02.02.2012 12:16, Richard Laager wrote: >>> GRUB can't write to ZFS. Creating a grubenv file leads to a misleading >>> "sparse file not allowed" error on boot. The attached patch for >>> grub-install skips the creation of a grubenv file on ZFS. >> This isn't specific to ZFS. BtrFS, squash4, all variants of cpio, tar >> and romfs are affected by the same problem. Could you expand your patch >> to handle those? > I suspect that handling them by name is not the best way to do this. How > can I tell if a filesystem doesn't support writing? I think it's the best way. One could use grub-fstest blocklist but it has other problems. While btrfs and zfs don't hook blocklist on purpose (COW and, more importantly, checksums), others are just almost never sector-aligned or are compressed. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko