From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards
Date: Fri, 03 Feb 2012 12:34:22 +0100 [thread overview]
Message-ID: <4F2BC63E.2040406@peak-system.com> (raw)
In-Reply-To: <4F2BBE24.5090601@grandegger.com>
Le 03/02/2012 11:59, Wolfgang Grandegger a écrit :
>
> Well, that is even more confusing. What happens if there is no LED
> support. If the LEDs are not blinking or illuminated users might think
> the card is not working. I would go for CAN_PEAK_PCIEC config enabling
> the support for the PCIEC *explicitly*. I mean, no support for the PCIEC
> if CAN_PEAK_PCIEC is not enabled. You may want to use the select trick
> if you prefer on that config. What do the others think?
Ok this argument is valid. Back to Oliver proposal.
The main reason why I generally prefer the "select" way is that the
"depends on" hides the menu item/choice text to the user.
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2012-02-03 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 13:19 [PATCH v4.3] peak_pci: add support for PEAK-System PCIe/PCIeC/miniPCI cards Stephane Grosjean
2012-02-02 18:03 ` Oliver Hartkopp
2012-02-02 23:06 ` Oliver Hartkopp
2012-02-03 10:14 ` Stephane Grosjean
2012-02-03 10:19 ` Wolfgang Grandegger
2012-02-03 10:44 ` Stephane Grosjean
2012-02-03 10:59 ` Wolfgang Grandegger
2012-02-03 11:34 ` Stephane Grosjean [this message]
2012-02-03 12:01 ` Stephane Grosjean
2012-02-03 12:28 ` Wolfgang Grandegger
2012-02-03 13:02 ` Stephane Grosjean
2012-02-03 12:09 ` Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2BC63E.2040406@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.