All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Farina <sidhayn@gmail.com>
To: Luciano Coelho <coelho@ti.com>
Cc: mcgrof@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] cleanup modprobe calls
Date: Fri, 03 Feb 2012 09:13:49 -0500	[thread overview]
Message-ID: <4F2BEB9D.20909@gmail.com> (raw)
In-Reply-To: <1328248669.3626.328.camel@cumari>

On 02/03/12 00:57, Luciano Coelho wrote:
> On Thu, 2012-02-02 at 21:48 -0500, Rick Farina wrote: 
>> There were a lot of needless calls to "modprobe -l <drivername>" and even more confusingly $(MODPROBE).
>> None of this is needed on a modern distro, and it errors on when modprobe -l is removed (such as KMOD in Arch Linux)
>>
>> Signed-of-By: Rick Farina <sidhayn@gmail.com>
>> ---
> I agree with this.  The modprobes are just there in order to list which
> of the relevant modules you have in your system.  There is little value
> in this and, if considered really necessary, there surely must be other
> ways to find out?
>
Although I've never liked all this scrolling, I would have recoded it
rather than removed it if I knew how.  At the present time there is no
way which I know to replicate this functionality. I suppose a find
statement could be added but honestly I just don't see it as necessary,
or any cleaner.

thanks,
Rick Farina

  reply	other threads:[~2012-02-03 14:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03  2:48 [PATCH 1/2] replace modprobe -l with modinfo Rick Farina
2012-02-03  2:48 ` [PATCH 2/2] cleanup modprobe calls Rick Farina
2012-02-03  5:57   ` Luciano Coelho
2012-02-03 14:13     ` Richard Farina [this message]
2012-02-03 14:18       ` Luciano Coelho
2012-02-03 14:31         ` Richard Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2BEB9D.20909@gmail.com \
    --to=sidhayn@gmail.com \
    --cc=coelho@ti.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.