From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] Add intel_panel_fitter tool
Date: Fri, 03 Feb 2012 10:39:18 -0800
Message-ID: <4F2C29D6.2000804@bwidawsk.net>
References: <1328281766-15792-1-git-send-email-przanoni@gmail.com>
	<e39f63$3ipbsm@fmsmga002.fm.intel.com>
	<CA+gsUGTi=bTKHpBmXxUKO_x1VUBGdAs=_=3Ab6MybC2V+kGpGA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id EA5569E732
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  3 Feb 2012 10:39:26 -0800 (PST)
In-Reply-To: <CA+gsUGTi=bTKHpBmXxUKO_x1VUBGdAs=_=3Ab6MybC2V+kGpGA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 02/03/12 08:44, Paulo Zanoni wrote:
> 2012/2/3 Chris Wilson<chris@chris-wilson.co.uk>:
>> I don't this should an installable tool for use by end-users. Direct
>> register access from userspace to registers that the driver owns? I'm
>> wary of installing even root-only tools that can screw us over in
>> unpredictable ways.
>> -Chris
>
> My idea is to write a patch that adds kernel peroperties to solve
> this, but while people still don't have kernel 3.4, the tool would be
> useful.
>
> If adding this tool to i-g-t is not a good idea, that's fine too: I
> still plan to write the kernel patches, so people wanting overscan
> compensation will have to use the kernel patch instead of the tool.

I didn't read that email from Chris as don't add it. I read it as,
don't have it installed if they do make install or something. So I
think he should clarify himself. If this benefits end users now - I'm
all for it.

However it should somehow enforce that it is running as root. The most
reusable way is to use the register_access_init functions designed for
forcewake.

Ben