From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtTjC-0005BV-G6 for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:43:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtTjB-0005Cu-DR for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:43:42 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:45712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtTjB-0005Cn-3G for qemu-devel@nongnu.org; Fri, 03 Feb 2012 19:43:41 -0500 Received: by werh12 with SMTP id h12so3696278wer.4 for ; Fri, 03 Feb 2012 16:43:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F2C7F3A.50306@redhat.com> Date: Sat, 04 Feb 2012 01:43:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328201142-26145-1-git-send-email-pbonzini@redhat.com> <1328201142-26145-11-git-send-email-pbonzini@redhat.com> <4F2AECE6.1060602@codemonkey.ws> <4F2AEFE7.9020901@redhat.com> <4F2BEBD1.3040908@codemonkey.ws> <4F2C79F0.9090904@redhat.com> In-Reply-To: <4F2C79F0.9090904@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org On 02/04/2012 01:21 AM, Paolo Bonzini wrote: > I'm not sure... we would trade removal of an ugly concept (the legacy > properties) with addition of a layering violation (poking into the > DeviceState subclasses). The main problem here is that you said no to a hierarchy of property classes. This is what would be good here: being able to say "does this property have legacy print/parse methods?" and call them if available from device_add. So, you can choose your poison. :) For now I think the idea in this patch series is good enough for its purpose (which is to actually _use_ QOM), we can tweak the design and really eliminate the legacy properties later. I don't mind going through multiple iterations as long as the state after each iteration is clearly better than before. f Paolo