All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, laurent.pinchart@ideasonboard.com,
	khilman@ti.com
Subject: Re: [RFC 1/1] omap3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE
Date: Sat, 04 Feb 2012 14:11:28 +0200	[thread overview]
Message-ID: <4F2D2070.8060701@iki.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1202011458490.10541@utopia.booyaka.com>

Paul Walmsley wrote:
> On Fri, 27 Jan 2012, Sakari Ailus wrote:
> 
>> MPU and CORE should stay awake if there is CAM domain ACTIVE.
> 
> I guess this should read that MPU and CORE should stay awake if the ISP IP 
> block is active?
> 
>> This is because that module doesn't have wake-up capability.
>>
>> The original patch was written by Jouni Högander in 2008 and this is the
>> last part left of it which is not in upstream yet.
>>
>> I wonder if the approach taken in the patch is valid these days;
>> nevertheless it seems to do the job...
> 
> Unfortunately we do not yet have a Linux generic framework for this sort 
> of thing yet, and Tony doesn't want to add more platform_data function 
> pointers.  So in the interim, would suggest following an 
> approach similar to the patch at the bottom of this message:
> 
> http://www.spinics.net/lists/linux-omap/msg63495.html
> 
> using PM QoS constraints to get what you want.  Make sure you keep the big 
> nasty comment in there.  That way, when someone manages to get some 
> generic support in for it, we can convert it over easily.
> 
> We should probably be marking all of these IP blocks with broken wakeup 
> with a hwmod flag also, for warning purposes if nothing else.  "Warning, 
> missing IP block wakeup line; energy consumption will be higher than 
> necessary; please annoy your silicon vendor"

Thanks Kevin, Paul and Jean!

I think we'll then make a similar change to the ISP driver until the
matter is resolved in a generic way.

Regards,

-- 
Sakari Ailus
sakari.ailus@iki.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2012-02-04 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 10:00 [RFC 1/1] omap3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE Sakari Ailus
2012-01-27 11:06 ` Jean Pihet
2012-01-27 14:03   ` Sakari Ailus
2012-01-31  9:34     ` Jean Pihet
2012-01-31 17:23       ` Kevin Hilman
2012-02-01 22:19 ` Paul Walmsley
2012-02-04 12:11   ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2D2070.8060701@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=khilman@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.