From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtjfS-0007Us-Ne for qemu-devel@nongnu.org; Sat, 04 Feb 2012 12:44:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtjfR-0007fC-1r for qemu-devel@nongnu.org; Sat, 04 Feb 2012 12:44:54 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:55403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtjfQ-0007f4-Od for qemu-devel@nongnu.org; Sat, 04 Feb 2012 12:44:53 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id A24EF1A9DD246 for ; Sat, 4 Feb 2012 18:44:51 +0100 (CET) Message-ID: <4F2D6E8E.2030609@web.de> Date: Sat, 04 Feb 2012 18:44:46 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA9AA3FD9D6767B2768AF5EDA" Subject: Re: [Qemu-devel] [PATCH] Fix memory dirty getting API change fallout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Avi Kivity , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA9AA3FD9D6767B2768AF5EDA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-02-04 18:39, Blue Swirl wrote: > Fix confusion in length calculation in commit > cd7a45c95ecf2404810f3c6becb7cb83c5010ad8. >=20 > Reported-by: Jan Kiszka > Signed-off-by: Blue Swirl > --- > hw/framebuffer.c | 2 +- > hw/sm501.c | 4 ++-- > hw/vga.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/framebuffer.c b/hw/framebuffer.c > index ea122fb..f4747cd 100644 > --- a/hw/framebuffer.c > +++ b/hw/framebuffer.c > @@ -87,7 +87,7 @@ void framebuffer_update_display( > dest +=3D i * dest_row_pitch; >=20 > for (; i < rows; i++) { > - dirty =3D memory_region_get_dirty(mem, addr, addr + src_width,= > + dirty =3D memory_region_get_dirty(mem, addr, src_width, > DIRTY_MEMORY_VGA); > if (dirty || invalidate) { > fn(opaque, dest, src, cols, dest_col_pitch); > diff --git a/hw/sm501.c b/hw/sm501.c > index 94c0abf..786e076 100644 > --- a/hw/sm501.c > +++ b/hw/sm501.c > @@ -1327,8 +1327,8 @@ static void sm501_draw_crt(SM501State * s) > ram_addr_t page1 =3D offset + width * src_bpp - 1; >=20 > /* check dirty flags for each line */ > - update =3D memory_region_get_dirty(&s->local_mem_region, page0= , page1, > - DIRTY_MEMORY_VGA); > + update =3D memory_region_get_dirty(&s->local_mem_region, page0= , > + page1 - page0, DIRTY_MEMORY_V= GA); >=20 > /* draw line and change status */ > if (update) { > diff --git a/hw/vga.c b/hw/vga.c > index d87c4f9..d27700d 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -1779,7 +1779,7 @@ static void vga_draw_graphic(VGACommonState *s, > int full_update) > } > page0 =3D addr; > page1 =3D addr + bwidth - 1; > - update =3D memory_region_get_dirty(&s->vram, page0, page1, > + update =3D memory_region_get_dirty(&s->vram, page0, page1 - pa= ge0, > DIRTY_MEMORY_VGA); > /* explicit invalidation for the hardware cursor */ > update |=3D (s->invalidated_y_table[y >> 5] >> (y & 0x1f)) & 1= ; Nope, doesn't help yet. It's particularly bad with the SDL GUI. Jan --------------enigA9AA3FD9D6767B2768AF5EDA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8tbpAACgkQitSsb3rl5xR2DQCg4TfAz3RooIkxYRRKh1uxeB2u sekAoN4a6scPWWLFmyyoBtLMg96xTg/t =8CtB -----END PGP SIGNATURE----- --------------enigA9AA3FD9D6767B2768AF5EDA--