From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Rto7q-0003sk-9I for mharc-grub-devel@gnu.org; Sat, 04 Feb 2012 17:30:30 -0500 Received: from eggs.gnu.org ([140.186.70.92]:36065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rto7k-0003sO-OM for grub-devel@gnu.org; Sat, 04 Feb 2012 17:30:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rto7g-0005xg-4T for grub-devel@gnu.org; Sat, 04 Feb 2012 17:30:24 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:64232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rto7f-0005xX-Te for grub-devel@gnu.org; Sat, 04 Feb 2012 17:30:20 -0500 Received: by wera13 with SMTP id a13so4539451wer.0 for ; Sat, 04 Feb 2012 14:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=yJeSt0jYTaEs1FhUYRBR8SjFnejeX86bkdXUGgePEW0=; b=QhFPdwmV5httdHVbw7QW4wOxcyyAKzTkId/jAPZ1fAiRkRYAg4yMC2FSbxyzpKNpVt hE8eCe7hE26oON3CY6qoK8i7fR/suyJf0iVgLhJ8M9dgCKB10h+qXyl8wUJmZlzfxTd5 daYmAO1vf3ciUI2Dy7vrWAMiSTJMlwGZKevVo= Received: by 10.216.133.40 with SMTP id p40mr1238356wei.20.1328394618853; Sat, 04 Feb 2012 14:30:18 -0800 (PST) Received: from fedora.x201.phnet (79-5.62-81.cust.bluewin.ch. [81.62.5.79]) by mx.google.com with ESMTPS id ho4sm15432072wib.3.2012.02.04.14.30.17 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 04 Feb 2012 14:30:17 -0800 (PST) Message-ID: <4F2DB177.8080303@gmail.com> Date: Sat, 04 Feb 2012 23:30:15 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error References: <1328392877.5007.38.camel@watermelon.coderich.net> In-Reply-To: <1328392877.5007.38.camel@watermelon.coderich.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 Cc: Richard Laager X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2012 22:30:28 -0000 On 04.02.2012 23:01, Richard Laager wrote: > disk/diskfilter.c: In function 'grub_diskfilter_make_raid': > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in > this function [-Werror=uninitialized] > > Perhaps my patch should use assert() instead of return NULL? We don't use assert since assert failures are usually not fatal. And failing to boot just because some otherwise unused disk has a RAID-9 isn't reasonable. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko