From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Grégoire Sutre" <gregoire.sutre@gmail.com>
Subject: Re: Build break (uninitialized variable)
Date: Sat, 04 Feb 2012 23:31:49 +0100 [thread overview]
Message-ID: <4F2DB1D5.8070200@gmail.com> (raw)
In-Reply-To: <4F2C26C3.6050804@gmail.com>
On 03.02.2012 19:26, Grégoire Sutre wrote:
> The compiler complains about `totsize' being possibly uninitialized
> in grub-core/disk/diskfilter.c, function grub_diskfilter_make_raid().
> I get this error with gcc 4.5.3 on NetBSD, and also with gcc 4.6.2 on
> Debian GNU/Linux.
>
> I'm not familiar with that code. The attached patch fixes this by
> returning NULL when the argument `level' has an unexpected value.
>
I've looked at other code and seen that return NULL will result in the
skipping of those devices altogether, exactly what we want. So I think
it's a reasonable behaviour for this function. So go ahead
> Grégoire
>
> gcc -DHAVE_CONFIG_H -I. -I.. -Wall -W -I../include -I../include
> -DGRUB_MACHINE_PCBIOS=1 -DGRUB_MACHINE=I386_PC
> -DGRUB_TARGET_CPU_I386=1 -m32 -DGRUB_FILE=\"disk/diskfilter.c\" -I.
> -I. -I.. -I.. -I../include -I../include -Os -Wall -W -Wshadow
> -Wpointer-arith -Wmissing-prototypes -Wundef -Wstrict-prototypes -g
> -falign-jumps=1 -falign-loops=1 -falign-functions=1 -mno-mmx -mno-sse
> -mno-sse2 -mno-3dnow -fno-dwarf2-cfi-asm
> -fno-asynchronous-unwind-tables -m32 -fno-stack-protector
> -mno-stack-arg-probe -Werror -mrtd -mregparm=3 -ffreestanding
> -MT disk/diskfilter_module-diskfilter.o -MD -MP -MF
> disk/.deps-core/diskfilter_module-diskfilter.Tpo -c -o
> disk/diskfilter_module-diskfilter.o `test -f 'disk/diskfilter.c' ||
> echo './'`disk/diskfilter.c
> cc1: warnings being treated as errors
> disk/diskfilter.c: In function 'grub_diskfilter_make_raid':
> disk/diskfilter.c:813:17: error: 'totsize' may be used uninitialized
> in this function
> gmake[3]: *** [disk/diskfilter_module-diskfilter.o] Error 1
> gmake[3]: Leaving directory `/tmp/grub/grub-core'
> gmake[2]: *** [all] Error 2
> gmake[2]: Leaving directory `/tmp/grub/grub-core'
> gmake[1]: *** [all-recursive] Error 1
> gmake[1]: Leaving directory `/tmp/grub'
> gmake: *** [all] Error 2
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
next prev parent reply other threads:[~2012-02-04 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 18:26 Build break (uninitialized variable) Grégoire Sutre
2012-02-04 22:31 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2012-02-05 0:31 ` Grégoire Sutre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2DB1D5.8070200@gmail.com \
--to=phcoder@gmail.com \
--cc=gregoire.sutre@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.