From: Mike Gilbert <floppym@gentoo.org>
To: grub-devel@gnu.org
Subject: Re: [MERGE] Add a --disable-zfs configure flag.
Date: Sat, 04 Feb 2012 17:36:43 -0500 [thread overview]
Message-ID: <4F2DB2FB.5090309@gentoo.org> (raw)
In-Reply-To: <4F2D9912.5040702@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On 02/04/2012 03:46 PM, Mike Gilbert wrote:
> I have the libzfs headers in /usr/include/libzfs, which is where the ZFS
> on Linux build system puts them. My best guess is that it isn't finding
> libzfs.h, but I haven't really dug in.
>
As it turns out, there are a few things going on here:
1. grub's configure is failing to detect libnvpair due to some breakage
upstream. See https://github.com/zfsonlinux/zfs/issues/560 .
2. getroot.c only includes libzfs.h if HAVE_LIBZFS and HAVE_LIBNVPAIR
are defined.
3. getroot.c references libzfs_handle_t if HAVE_LIBZFS is set, but does
not look at HAVE_LIBNVPAIR.
So, getroot.c is trying to use a ZFS structure without including the ZFS
header(s).
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 230 bytes --]
next prev parent reply other threads:[~2012-02-04 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 19:56 [MERGE] Add a --disable-zfs configure flag Mike Gilbert
2012-02-04 20:06 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-02-04 20:46 ` Mike Gilbert
2012-02-04 21:41 ` Richard Laager
2012-02-04 22:13 ` Mike Gilbert
2012-02-04 22:36 ` Mike Gilbert [this message]
2012-02-05 1:12 ` Mike Gilbert
2012-02-05 3:40 ` Darik Horn
2012-02-05 5:44 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2DB2FB.5090309@gentoo.org \
--to=floppym@gentoo.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.