All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: David Miller <davem@davemloft.net>
Cc: shawn.lu@ericsson.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, xiaoclu@gmail.com
Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case
Date: Sat, 04 Feb 2012 17:52:45 -0800	[thread overview]
Message-ID: <4F2DE0ED.7020708@candelatech.com> (raw)
In-Reply-To: <20120204.162602.1922697409850241775.davem@davemloft.net>

On 02/04/2012 01:26 PM, David Miller wrote:
> From: Shawn Lu<shawn.lu@ericsson.com>
> Date: Sat, 4 Feb 2012 13:22:36 -0800
>
>> +	/*
>> +	 * When socket is gone, all binding information is lost.
>> +	 * routing might fail in this case. using iif for oif to
>> +	 * make sure we can deliver it
>> +	 */
>
> Comment is poorly formatted, and I'm getting tired of teaching
> people
>
> 	/* That comments are formatted like
> 	 * this.
> 	 */
>
> 	/*
> 	 * Not like this.
> 	 */

I agree with your taste in comments, but the linux style guide
says basically the opposite.  Maybe see if you can sneak a patch
into the style guide? :)

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  parent reply	other threads:[~2012-02-05  1:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <RE: [PATCH] tcp: RST: binding oif to iif for tcp v4>
2012-02-04 21:22 ` [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case Shawn Lu
2012-02-04 21:26   ` David Miller
2012-02-04 21:30     ` Shawn Lu
2012-02-04 21:34     ` [PATCH] CodingStyle: Add net and drivers/net preferred commenting style Joe Perches
2012-02-04 21:40       ` David Miller
2012-02-04 21:50         ` Joe Perches
2012-02-04 21:53           ` David Miller
2012-02-04 22:02             ` Joe Perches
2012-02-05  1:52     ` Ben Greear [this message]
     [not found] <RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case>
2012-02-04 21:44 ` [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case Shawn Lu
2012-02-04 21:47   ` David Miller
2012-02-04 22:47     ` Shawn Lu
2012-02-04 21:49   ` Eric Dumazet
2012-02-04 22:38 ` Shawn Lu
2012-02-04 23:20   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2DE0ED.7020708@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.lu@ericsson.com \
    --cc=xiaoclu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.