From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH V3 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of non-slave transfers Date: Mon, 6 Feb 2012 13:41:40 +0530 Message-ID: <4F2F8B3C.7050107@st.com> References: <20120202121523.GG889@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120202121523.GG889@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: Rajeev KUMAR , Bhupesh SHARMA , "linus.walleij@linaro.org" , "perex@perex.cz" , Vipin KUMAR , Mirko GARDI , Vincenzo FRASCINO , Pratyush ANAND , "vinod.koul@intel.com" , Deepak SIKRI , "cjb@laptop.org" , "hskinnemoen@gmail.com" , Bhavna YADAV , Armando VISCONTI , "egtvedt@samfundet.no" , Shiraz HASHIM , Amit VIRDI , Vipul Kumar SAMAR , "dan.j.williams@intel.com" , Ulf HANSSON , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org On 2/2/2012 5:45 PM, Russell King - ARM Linux wrote: > I'm still unconvinced that this is anywhere close to correct. > > Look. DMA engines only automatically unmap when they're being used by the > async_tx stuff for memcpy's, and RAID computation offload, and the like. > These work with individual single buffers, not scatterlists. These will > not be fragmented. Got it. You are right. @Vinod: Please drop this patch. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (Viresh Kumar) Date: Mon, 6 Feb 2012 13:41:40 +0530 Subject: [PATCH V3 08/12] dmaengine/dw_dmac: Unmap all memory buffers after completion of non-slave transfers In-Reply-To: <20120202121523.GG889@n2100.arm.linux.org.uk> References: <20120202121523.GG889@n2100.arm.linux.org.uk> Message-ID: <4F2F8B3C.7050107@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2/2/2012 5:45 PM, Russell King - ARM Linux wrote: > I'm still unconvinced that this is anywhere close to correct. > > Look. DMA engines only automatically unmap when they're being used by the > async_tx stuff for memcpy's, and RAID computation offload, and the like. > These work with individual single buffers, not scatterlists. These will > not be fragmented. Got it. You are right. @Vinod: Please drop this patch. -- viresh