From: "Andreas Färber" <afaerber@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-ppc@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ppc: remove unused variables
Date: Mon, 06 Feb 2012 16:21:38 +0100 [thread overview]
Message-ID: <4F2FF002.4020001@suse.de> (raw)
In-Reply-To: <CAAu8pHtCoqKbf0uvb0bDvn5LXrvLFSbFx7dcPLqT4LyUyGZ5AQ@mail.gmail.com>
Am 04.02.2012 12:49, schrieb Blue Swirl:
> Fix this error:
> /src/qemu/target-ppc/helper.c: In function 'booke206_tlb_to_page_size':
> /src/qemu/target-ppc/helper.c:1296:14: error: variable 'tlbncfg' set
> but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Tested-by: Andreas Färber <afaerber@suse.de>
Alex?
Andreas
> ---
> target-ppc/helper.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/target-ppc/helper.c b/target-ppc/helper.c
> index e56fac8..928fbcf 100644
> --- a/target-ppc/helper.c
> +++ b/target-ppc/helper.c
> @@ -1293,11 +1293,8 @@ void booke206_flush_tlb(CPUState *env, int
> flags, const int check_iprot)
>
> target_phys_addr_t booke206_tlb_to_page_size(CPUState *env, ppcmas_tlb_t *tlb)
> {
> - uint32_t tlbncfg;
> - int tlbn = booke206_tlbm_to_tlbn(env, tlb);
> int tlbm_size;
>
> - tlbncfg = env->spr[SPR_BOOKE_TLB0CFG + tlbn];
> tlbm_size = (tlb->mas1 & MAS1_TSIZE_MASK) >> MAS1_TSIZE_SHIFT;
>
> return 1024ULL << tlbm_size;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-06 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 11:49 [Qemu-devel] [PATCH] ppc: remove unused variables Blue Swirl
2012-02-06 15:21 ` Andreas Färber [this message]
2012-02-06 15:57 ` Alexander Graf
2012-02-11 11:07 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2FF002.4020001@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.