From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chase Douglas Subject: Re: [PATCH v4] Input: Add EVIOC mechanism for MT slots Date: Mon, 06 Feb 2012 19:27:31 +0100 Message-ID: <4F301B93.4030306@gmail.com> References: <1328515542-3779-1-git-send-email-rydberg@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:48920 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555Ab2BFS0Y (ORCPT ); Mon, 6 Feb 2012 13:26:24 -0500 In-Reply-To: <1328515542-3779-1-git-send-email-rydberg@euromail.se> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Henrik Rydberg Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On 02/06/2012 09:05 AM, Henrik Rydberg wrote: > This patch adds the ability to extract MT slot data via a new ioctl, > EVIOCGMTSLOTS. The function returns an array of slot values for the > specified ABS_MT event type. > > Example of user space usage: > > struct { unsigned code; int values[64]; } req; > req.code = ABS_MT_POSITION_X; > if (ioctl(fd, EVIOCGMTSLOTS(sizeof(req)), &req) < 0) > return -1; > for (i = 0; i < 64; i++) > printf("slot %d: %d\n", i, req.values[i]); > > Signed-off-by: Henrik Rydberg > --- > Here is the fourth version of the patch. > > Rather than over-specifying the ioctl binary format by introducing a > struct object that does not fit everyone, this version simply leaves > all object definitions to userland. This is fine with me. I think the ioctl macro definition would be easier to work with if it took the number of values instead of the size of the request, but it's a nit-pick. If Dmitry thinks this is good enough, it's good enough for me too :). Reviewed-by: Chase Douglas Thanks!