From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>, Mel Gorman <mel@csn.ul.ie>,
Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] compact_pgdat: workaround lockdep warning in kswapd
Date: Mon, 06 Feb 2012 16:48:11 -0500 [thread overview]
Message-ID: <4F304A9B.2030004@redhat.com> (raw)
In-Reply-To: <20120206124952.75702d5c.akpm@linux-foundation.org>
On 02/06/2012 03:49 PM, Andrew Morton wrote:
> On Mon, 6 Feb 2012 11:40:08 -0800 (PST)
> Hugh Dickins<hughd@google.com> wrote:
>
>> I get this lockdep warning from swapping load on linux-next
>> (20120201 but I expect the same from more recent days):
>
> The patch looks good as a standalone optimisation/cleanup. The lack of
> clarity on the lockdep thing is a concern - I have a feeling we'll be
> bitten again.
Very strange, kswapd does not seem to be holding any locks
when calling balance_pgdat...
I assume it must be this line in kswapd() that's causing
lockdep to trigger:
lockdep_set_current_reclaim_state(GFP_KERNEL);
> This fix seems to be applicable to mainline?
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-06 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 19:40 [PATCH] compact_pgdat: workaround lockdep warning in kswapd Hugh Dickins
2012-02-06 20:49 ` Andrew Morton
2012-02-06 21:00 ` Hugh Dickins
2012-02-06 21:48 ` Rik van Riel [this message]
2012-02-06 22:14 ` Hugh Dickins
2012-02-09 15:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F304A9B.2030004@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.