From: Stephen Boyd <sboyd@codeaurora.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Michal Marek <mmarek@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tags: fix regex passed to etags and ctags
Date: Mon, 06 Feb 2012 15:05:26 -0800 [thread overview]
Message-ID: <4F305CB6.7050603@codeaurora.org> (raw)
In-Reply-To: <20120206124058.1cf1a23e@s6510.linuxnetplumber.net>
On 02/06/12 12:40, Stephen Hemminger wrote:
> Several of the regular expressions passed to etags and ctags where incorrect
> and missing the backslash before the closing paren, causing warning:
> etags: Unmatched ( or \( while compiling pattern
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> ---
> v2 - cover all regex (not just etags)
>
Ok one more problem (my eyes hurt with all these parentheses).
--regex-c++='/PAGEFLAG\(([^,)]*\).*/Page\1/'
should be
--regex-c++='/PAGEFLAG(\([^,)]*\).*/Page\1/'
so that PAGEFLAG(Foo, ...) becomes PageFoo and not Page(Foo
After that:
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-02-06 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 19:27 [PATCH] tags: fix regex passed to etags Stephen Hemminger
2012-02-03 19:42 ` Stephen Boyd
2012-02-03 20:18 ` Stephen Hemminger
2012-02-06 20:32 ` Stephen Boyd
2012-02-06 20:40 ` [PATCH] tags: fix regex passed to etags and ctags Stephen Hemminger
2012-02-06 23:05 ` Stephen Boyd [this message]
2012-02-06 23:15 ` [PATCH] tags: fix use of parenthesis in regex Stephen Hemminger
2012-02-07 19:18 ` Stephen Boyd
2012-02-25 0:34 ` Michal Marek
2012-02-25 0:56 ` Stephen Hemminger
2012-02-25 9:37 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F305CB6.7050603@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.