From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Remove even more unused code
Date: Tue, 07 Feb 2012 09:00:15 +0200 [thread overview]
Message-ID: <4F30CBFF.8060408@bitmer.com> (raw)
In-Reply-To: <CAMP44s23-cDE3dVur0zgXLF0J7fjuJmrh5jD_E4zyrySKgYzwg@mail.gmail.com>
On 02/06/2012 10:48 PM, Felipe Contreras wrote:
> On Mon, Feb 6, 2012 at 9:28 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>> On Mon, Feb 06, 2012 at 07:23:13PM +0000, Mark Brown wrote:
>>> Now that we're not implement GPIO or microphone support there's no users
>>> for the read() function any more.
>>
>> That's microphone detect, not plain microphone.
>
> s/implement/implementing?
>
You can have my ack here (I'd have acked Felipe's earlier cleanup too
but noticed them only now). Support for gpio and detection were added
almost 4 years ago according to log without seeing any users in mainline
since then.
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
prev parent reply other threads:[~2012-02-07 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 19:23 [PATCH] ASoC: tlv320aic3x: Remove even more unused code Mark Brown
2012-02-06 19:28 ` Mark Brown
2012-02-06 20:48 ` Felipe Contreras
2012-02-07 7:00 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F30CBFF.8060408@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=felipe.contreras@gmail.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.