From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 3/4] iwlwifi: cleanup/fix memory barriers
Date: Tue, 07 Feb 2012 09:25:42 +0100 [thread overview]
Message-ID: <4F30E006.1000903@sipsolutions.net> (raw)
In-Reply-To: <20120207081115.GC2246@redhat.com>
On 2/7/2012 9:11 AM, Stanislaw Gruszka wrote:
>> Technically, PCIe bridges can reorder writes as well, so we really
>> need to do a dummy read somewhere -- we were discussing this
>> internally recently as well.
>
> PCIe can reorder writes only if they come from different CPUs,
> good examples are in "LOCKS VS I/O ACCESSES" in
> Documentation/memory-barriers.txt
Good point, I was confusing this and write posting. Don't think we have
an issue with write posting here so we should be OK.
johannes
next prev parent reply other threads:[~2012-02-07 8:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:09 [RFC 1/4] iwlwifi: dump stack when fail to gain access to the device Stanislaw Gruszka
2012-02-06 16:08 ` wwguy
2012-02-07 8:01 ` Stanislaw Gruszka
2012-02-07 14:21 ` Guy, Wey-Yi
2012-02-08 10:52 ` Stanislaw Gruszka
2012-02-06 16:09 ` [RFC 2/4] iwlwifi: always check if got h/w access before write Stanislaw Gruszka
2012-02-06 16:13 ` wwguy
2012-02-07 8:05 ` Stanislaw Gruszka
2012-02-07 14:20 ` Guy, Wey-Yi
2012-02-06 16:09 ` [RFC 3/4] iwlwifi: cleanup/fix memory barriers Stanislaw Gruszka
2012-02-06 16:13 ` Johannes Berg
2012-02-07 8:11 ` Stanislaw Gruszka
2012-02-07 8:25 ` Johannes Berg [this message]
2012-02-06 16:09 ` [RFC 4/4] iwlwifi: use writeb,writel,readl directly Stanislaw Gruszka
2012-02-06 16:32 ` wwguy
2012-02-07 8:22 ` Stanislaw Gruszka
2012-02-07 14:22 ` Guy, Wey-Yi
2012-02-10 12:01 ` [RFC 1/4] iwlwifi: dump stack when fail to gain access to the device Stanislaw Gruszka
2012-02-23 10:14 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F30E006.1000903@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.