From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Subject: Re: [PATCH] net: sh_eth: fix skb_over_panic happen
Date: Tue, 07 Feb 2012 17:35:52 +0900 [thread overview]
Message-ID: <4F30E268.6010100@renesas.com> (raw)
In-Reply-To: <1328601310.2476.3.camel@edumazet-laptop>
Hi Eric,
2012/02/07 16:55, Eric Dumazet wrote:
> Le mardi 07 février 2012 à 15:54 +0900, Shimoda, Yoshihiro a écrit :
[ snip ]
>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
>> index 813d41c..9e899b0 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -817,7 +817,7 @@ static int sh_eth_dev_init(struct net_device *ndev)
>> sh_eth_write(ndev, 0, TRIMD);
>>
>> /* Recv frame limit set register */
>> - sh_eth_write(ndev, RFLR_VALUE, RFLR);
>> + sh_eth_write(ndev, ndev->mtu + ETH_HLEN + ETH_FCS_LEN, RFLR);
>>
>
> No VLAN_HDR ?
>
Thank you for your point.
I forgot care of VLAN. I will add "+ VLAN_HLEN" and submit a patch.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2012-02-07 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 6:54 [PATCH] net: sh_eth: fix skb_over_panic happen Shimoda, Yoshihiro
2012-02-07 7:55 ` Eric Dumazet
2012-02-07 8:35 ` Shimoda, Yoshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F30E268.6010100@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.