All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] sh-eth: use netdev stats structure and fix dma_map_single
Date: Tue, 07 Feb 2012 18:19:30 +0900	[thread overview]
Message-ID: <4F30ECA2.7030603@renesas.com> (raw)
In-Reply-To: <1328602641.2476.12.camel@edumazet-laptop>

Hi Eric,

2012/02/07 17:17, Eric Dumazet wrote:
> No need to maintain a parallel net_device_stats structure in
> sh_eth_private, since we have a generic one in netdev
> 
> Fix two dma_map_single() incorrect parameters, passing skb->tail instead
> of skb->data. Seems that there is no corresponding dmap_unmap_single()
> calls for the moment in this driver.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> Please test this patch Yoshihiro before we can apply it, thanks !

Thank you for the patch.
I tested this patch and it worked correctly on my environment.
 - ping, NFS, FTP and read the statistics by sysfs

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

  reply	other threads:[~2012-02-07  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07  8:17 [PATCH net-next] sh-eth: use netdev stats structure and fix dma_map_single Eric Dumazet
2012-02-07  9:19 ` Shimoda, Yoshihiro [this message]
2012-02-07 18:39   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F30ECA2.7030603@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.