From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruq19-0007af-0u for qemu-devel@nongnu.org; Tue, 07 Feb 2012 13:43:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ruq17-00029X-Ur for qemu-devel@nongnu.org; Tue, 07 Feb 2012 13:43:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54309 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ruq17-00028Z-Ou for qemu-devel@nongnu.org; Tue, 07 Feb 2012 13:43:49 -0500 Message-ID: <4F317056.5030804@suse.de> Date: Tue, 07 Feb 2012 19:41:26 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1328237992-14953-1-git-send-email-afaerber@suse.de> <1328237992-14953-14-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC v3 13/21] target-arm: Store JTAG_ID in ARMCPUClass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Am 07.02.2012 18:47, schrieb Peter Maydell: > On 3 February 2012 02:59, Andreas F=C3=A4rber wrote: >> That way we can remove some more CPUID cases without losing info. >> >> Signed-off-by: Andreas F=C3=A4rber >> Cc: Peter Maydell >> Cc: Andrzej Zaborowski >> --- >> target-arm/cpu-core.h | 1 + >> target-arm/cpu.c | 2 ++ >> target-arm/cpu.h | 5 ----- >> target-arm/helper.c | 8 -------- >> 4 files changed, 3 insertions(+), 13 deletions(-) >> >> diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h >> index 3e7dfae..eac1a03 100644 >> --- a/target-arm/cpu-core.h >> +++ b/target-arm/cpu-core.h >> @@ -48,6 +48,7 @@ typedef struct ARMCPUClass { >> uint32_t c0_c2[8]; >> uint32_t c1_sys; >> } cp15; >> + uint64_t jtag_id; >=20 > If we're not using this anywhere we should just not have it. Andrzej will have had his reasons to put it in the code. This series just moves code around so I don't want to remove it without his ack. I cc'ed him in the hopes of getting an explanation. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg