From: Kevan Rehm <kfr@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer
Date: Tue, 07 Feb 2012 14:25:35 -0600 [thread overview]
Message-ID: <4F3188BF.4030403@sgi.com> (raw)
In-Reply-To: <20120207183830.GA31143@infradead.org>
On 02/07/2012 12:38 PM, Christoph Hellwig wrote:
> On Sun, Nov 13, 2011 at 07:01:33AM -0500, Christoph Hellwig wrote:
>> On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:
>>> From: Kevan Rehm<kfr@sgi.com>
>>>
>>> In phase 6, in mk_root_dir(), xfs_repair initializes the mount
>>> point's m_rootip pointer without accounting for that reference.
>>> This field never really used or needed in repair otherwise, and the
>>> assigned pointer doesn't really represent a real reference to an
>>> inode that needs to be cached. So just kill off this assignment.
>>>
>>> Signed-off-by: Alex Elder<aelder@sgi.com>
>> Shouldn't this also have Kevan's signoff?
> Kevan, can you give me a signoff for this patch, I'd like to put it in?
>
Fine by me.
Kevan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-02-07 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 20:35 [PATCH 0/8] xfsprogs: new resvsp db command, plus some fixes Alex Elder
2011-11-10 20:35 ` [PATCH 1/8] xfsprogs: Fix setbitval() bug when nbits is byte-aligned Alex Elder
2011-11-10 20:35 ` [PATCH 2/8] xfsprogs: unconditionally drop used buffer reference Alex Elder
2011-11-13 11:59 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer Alex Elder
2011-11-13 12:01 ` Christoph Hellwig
2012-02-07 18:38 ` Christoph Hellwig
2012-02-07 20:25 ` Kevan Rehm [this message]
2012-02-07 21:46 ` Kevan Rehm
2011-11-10 20:35 ` [PATCH 4/8] xfsprogs: mkfs.xfs: let libxfs_umount() do its thing Alex Elder
2011-11-13 12:04 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 5/8] xfsprogs: Drop root inode refrerence in libxfs_umount() Alex Elder
2011-11-13 12:07 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 6/8] xfsprogs: xfs_db: unmount fs before exiting Alex Elder
2011-11-13 12:09 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 7/8] xfsprogs: clean up errors in libxfs_mount() consistently Alex Elder
2011-11-14 10:28 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 8/8] xfsprogs: xfs_db: add new "resvsp" command Alex Elder
2011-11-11 1:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3188BF.4030403@sgi.com \
--to=kfr@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.