From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v2] x86, mm: Probe memory block size for generic x86 64bit
Date: Tue, 07 Feb 2012 14:11:46 -0800 [thread overview]
Message-ID: <4F31A1A2.8020201@zytor.com> (raw)
In-Reply-To: <1327911855-6501-1-git-send-email-yinghai@kernel.org>
On 01/30/2012 12:24 AM, Yinghai Lu wrote:
> Usually if the system support memory remapping to get back memory for mmio
> range, we will have 128M ... 2G at the end.
>
> Try to probe that size.
>
> So we can get less entries in /sys/devices/system/memory/
>
> -v2: don't probe it every time when /sys/../block_size_byte is showed...
>
Okay... what on Earth is the point of this?
This just screams "dangerous toxic heuristic that's likely to break
unusual configurations", and reducing the number of entries in a /sys
directory is hardly motivation for anything.
You need a much better description of what you're trying to accomplish
and why that matters in the first place.
-hpa
next prev parent reply other threads:[~2012-02-07 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 8:24 [PATCH -v2] x86, mm: Probe memory block size for generic x86 64bit Yinghai Lu
2012-02-07 22:11 ` H. Peter Anvin [this message]
2012-02-07 22:35 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F31A1A2.8020201@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.