From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [RFC PATCH] drm/vgem: virtual GEM provider Date: Tue, 07 Feb 2012 18:32:49 -0500 Message-ID: <4F31B4A1.8060208@redhat.com> References: <1326309561-21055-1-git-send-email-ajax@redhat.com> <87mx9u2dx3.fsf@eliezer.anholt.net> <1326315860.28557.91.camel@atropine> <20120207232857.GA19150@seagal.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 14C319E8EB for ; Tue, 7 Feb 2012 15:32:51 -0800 (PST) In-Reply-To: <20120207232857.GA19150@seagal.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Eric Anholt , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 2/7/12 6:28 PM, Ben Widawsky wrote: > On Wed, Jan 11, 2012 at 04:04:20PM -0500, Adam Jackson wrote: >>> If you can, I recommend using the intel gtt mapping type of mmap ioctl, >>> where it gives you back an offset that you use the mmap syscall on, and >>> implement the vgem_gem_fault to map its pages, instead. It should avoid >>> tricking userland tools like valgrind, which really sucks with the >>> do_mmap()-calling ioctl we have today. >> >> That makes sense. Having two paths by which you could hit >> drm_gem_mmap() seemed weird when I was writing it. >> >> I think the clean way of doing that requires exporting at least >> shmem_fault and possibly some other shmfs details. >> >> - ajax > > I'm working on this presently unless you've already done it. Go for it, I've been ratholed getting vesa working again on 1.12. - ajax