From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: Re: [PATCH] vpmu: Is CONFIG_SMP used anymore?
Date: Wed, 8 Feb 2012 14:05:08 +0000 [thread overview]
Message-ID: <4F328114.60506@citrix.com> (raw)
In-Reply-To: <CB57BF48.2A9B6%keir.xen@gmail.com>
On 08/02/12 05:57, Keir Fraser wrote:
> On 08/02/2012 13:14, "Dietmar Hahn" <dietmar.hahn@ts.fujitsu.com> wrote:
>
>> Hi,
>>
>> while locking at the vpmu stuff I found the following stuff:
>>
>> diff -r a55e0f9c7b4e xen/arch/x86/oprofile/nmi_int.c
>> --- a/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 12:28:47 2012 +0100
>> +++ b/xen/arch/x86/oprofile/nmi_int.c Wed Feb 08 14:11:06 2012 +0100
>> @@ -305,7 +305,7 @@ static int __init p4_init(char ** cpu_ty
>> }
>>
>> #ifndef CONFIG_SMP
>> - *cpu_type = "i386/p4", XENOPROF_CPU_TYPE_SIZE);
>> + *cpu_type = "i386/p4";
>> model = &op_p4_spec;
>> return 1;
>> #else
>>
>>
>> Is CONFIG_SMP always switched on? It seems nobody tested without CONFIG_SMP.
> Correct. !CONFIG_SMP isn't configurable or supported.
>
> -- Keir
A naive test:
andrewcoop@andrewcoop:/local/xen-unstable.hg/xen$ rgrep "CONFIG_SMP" * |
wc -l
166
Seems there are quite a few bits to remove. If noone has done so, when
I get round to gutting #ifdef __ia64__'s from the arch/x86 tree I shall
do the same with CONFIG_SMP.
~Andrew
>> Thanks.
>>
>> Dietmar.
>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next prev parent reply other threads:[~2012-02-08 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 13:14 [PATCH] vpmu: Is CONFIG_SMP used anymore? Dietmar Hahn
2012-02-08 5:57 ` Keir Fraser
2012-02-08 14:05 ` Andrew Cooper [this message]
2012-02-08 6:09 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F328114.60506@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.